Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/doc: turn URLs into links #2832

Closed
garyburd opened this issue Feb 2, 2012 · 3 comments
Closed

go/doc: turn URLs into links #2832

garyburd opened this issue Feb 2, 2012 · 3 comments
Milestone

Comments

@garyburd
Copy link
Contributor

garyburd commented Feb 2, 2012

The go/doc ToHTML does not convert URLs to links as described in the function
documentation and implemented in r60.3.

What steps will reproduce the problem?

Run the following application:

package main

import (
    "go/doc"
    "os"
)

func main() {
    doc.ToHTML(os.Stdout, "http://www.google.com/";, nil)
}

What is the expected output?

<p>
<a
href="http://www.google.com/";>http://www.google.com/<;/a></p>

What do you see instead?

<p>
http://www.google.com/<;/p>

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

Lion

Which revision are you using?  (hg identify)

1b6e7832103e tip

Please provide any additional information below.

The following application produces the expected output on r60.3.

package main

import (
    "go/doc"
    "os"
)

func main() {
    doc.ToHTML(os.Stdout, []byte("http://www.google.com/";), nil)
}
@rsc
Copy link
Contributor

rsc commented Feb 2, 2012

Comment 1:

Labels changed: added priority-go1, removed priority-triage.

Owner changed to builder@golang.org.

Status changed to Accepted.

@garyburd
Copy link
Contributor Author

garyburd commented Feb 2, 2012

Comment 2:

I will fix this.

@griesemer
Copy link
Contributor

Comment 3:

This was fixed at revision 1850ba379b84, http://golang.org/cl/5616060 .

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants