Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: reply to commit comments saying we do not monitor them #28296

Open
FiloSottile opened this issue Oct 20, 2018 · 12 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest
Milestone

Comments

@FiloSottile
Copy link
Contributor

We get from time to time a comment on a commit in the main repo. We do not monitor those and nobody gets a ping for them (except the author of the commit who might or might not check GitHub notifications and does not have to). gopherbot should reply automatically pointing them towards the issue tracker and https://github.com/golang/go/wiki/Questions.

(Almost sure there was an issue for this, but couldn't find it. Please close as dup if anyone does.)

@gopherbot gopherbot added this to the Unreleased milestone Oct 20, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 20, 2018
@AlexRouSg
Copy link
Contributor

I think it should be expanded to include closed issues too.

@gopherbot
Copy link

Change https://golang.org/cl/145238 mentions this issue: cmd/gopherbot: redirect comments on closed issues

@adamdecaf
Copy link
Contributor

The CL mentioned lowering our freeze timeout for closed issues instead. Right now the timeout is 365 days. 30 days? 90?

@ianlancetaylor
Copy link
Contributor

I say 30 days, and make sure that the freeze notice mentions https://golang.org/wiki/Questions .

@gopherbot
Copy link

Change https://golang.org/cl/145658 mentions this issue: cmd/gopherbot: freeze issues after 30 days, link to Questions wiki page

@FiloSottile
Copy link
Contributor Author

There is no freeze notice currently, and I think sending a comment on all issues 30 days after closing would be extremely spammy. Did you mean something different? We could put it in the description of the FrozenDueToAge label although that’s not very discoverable.

@ianlancetaylor
Copy link
Contributor

Good point. I was thinking that there was a notice on the issue when we freeze it, but of course you're right that there isn't. In that case, sure, 90 days seems plausible to me.

Sorry for the runaround.

@adamdecaf
Copy link
Contributor

What about adding the freeze notice only to issues that have had a comment after the issue is closed?

@andybons
Copy link
Member

So 90 days without a comment on the issue?

@dmitshur
Copy link
Contributor

dmitshur commented Feb 3, 2019

(Almost sure there was an issue for this, but couldn't find it. Please close as dup if anyone does.)

@FiloSottile That issue is #25450. It was a proposal to tackle this problem, and it was approved.

It's currently tracking a slightly different implementation approach to solve the same problem: to lock the conversations on commits, so that people can't spend time writing up a comment only to have it ignored.

However, the implementation is blocked on GitHub exposing a programmatic way to lock conversation on comments. Both GitHub API v3 and v4 currently only allow locking conversations on issues and PRs, but not yet on commits. See #25450 (comment) for more details about that. I tried pinging GitHub asking if this will be done, and got the usual "it'll be done when it's done" reply. As soon as GitHub exposes such an API, I can implement the fix.

@gopherbot
Copy link

Change https://golang.org/cl/284713 mentions this issue: commitcommentshook: politely respond to commit comments on golang/go

@gopherbot

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest
Projects
None yet
Development

No branches or pull requests

7 participants