Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: "invalid recursive type" should abort #28294

Closed
bep opened this issue Oct 20, 2018 · 2 comments
Closed

cmd/compile: "invalid recursive type" should abort #28294

bep opened this issue Oct 20, 2018 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@bep
Copy link
Contributor

bep commented Oct 20, 2018

This seems to be similar to #21273 (fixed in Go 1.10).

▶ go version
go version go1.11 darwin/amd64
package main

func main() {
	type int int
	type I int

	const i I = 1
}

The above fails with

./main.go:4:7: invalid recursive type int
./main.go:5:7: invalid recursive type I
./main.go:7:8: invalid constant type I

The above is clear enough in this small case, but I had this happen to me (again, an automatic refactoring gone wrong) in a bigger program and all I saw was a list of invalid constant type (that looked valid), and then too many errors.
@meirf
Copy link
Contributor

meirf commented Oct 20, 2018

Maybe this case should follow the same logic as here:

There's no need to tell me T is an invalid map key after telling me it's an invalid anything.

This case is trickier though since I is typed of the original error type.

cc @griesemer

@griesemer griesemer self-assigned this Oct 20, 2018
@griesemer griesemer added this to the Unplanned milestone Oct 20, 2018
@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 20, 2018
@griesemer
Copy link
Contributor

This is now (Go 1.18) reporting:

./prog.go:4:7: invalid recursive type int
	./prog.go:4:7: int refers to
	./prog.go:4:7: int

which seems reasonable. Closing as working as expected.

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@bep @meirf @griesemer @gopherbot