Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: remove commented debug prints #28234

Closed
minaevmike opened this issue Oct 16, 2018 · 4 comments
Closed

database/sql: remove commented debug prints #28234

minaevmike opened this issue Oct 16, 2018 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@minaevmike
Copy link
Contributor

there are some commented debug prints in database/sql package(like https://github.com/golang/go/blob/master/src/database/sql/sql.go#L600 and https://github.com/golang/go/blob/master/src/database/sql/sql.go#L570) , i think they can be deleted.
@FiloSottile
Copy link
Contributor

Permalinks:

go/src/database/sql/sql.go

Line 600 in e861c3e

//println(fmt.Sprintf("removeDep(%T %p, %T %p)", x, x, dep, dep))

go/src/database/sql/sql.go

Line 570 in e861c3e

//println(fmt.Sprintf("addDep(%T %p, %T %p)", x, x, dep, dep))

@FiloSottile FiloSottile added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Oct 16, 2018
@FiloSottile FiloSottile added this to the Go1.12 milestone Oct 16, 2018
@abhijitherekar
Copy link

@FiloSottile Hi, Can I pick this?

@cuonglm
Copy link
Member

cuonglm commented Oct 17, 2018

@abhijitherekar just send a CL

@darkLord19 darkLord19 mentioned this issue Oct 17, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/142877 mentions this issue: database/sql: remove commented debug prints

@golang golang locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
5 participants
@FiloSottile @minaevmike @cuonglm @gopherbot @abhijitherekar