Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal/ssa test TestNexting failing #28198

Closed
ALTree opened this issue Oct 14, 2018 · 4 comments
Closed

cmd/compile: internal/ssa test TestNexting failing #28198

ALTree opened this issue Oct 14, 2018 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@ALTree
Copy link
Member

ALTree commented Oct 14, 2018

Change 0e9f8a2 (runtime,cmd/compile: pass strings and slices to convT2{E,I} by value) broke the TestNexting/gdb-opt-hist test in the cmd/compile/internal/ssa package:

$ cd src/cmd/compile/internal/ssa

$ gotip test -v -run=TestNexting/gdb-opt-hist
=== RUN   TestNexting
=== RUN   TestNexting/gdb-opt-hist
--- FAIL: TestNexting (0.45s)
    --- FAIL: TestNexting/gdb-opt-hist (0.45s)
        debug_test.go:241: step/next histories differ, diff=
            --- testdata/hist.gdb-opt.nexts	2018-10-03 18:58:59.969506742 +0200
            +++ /tmp/debug_test518566154/test-hist.gdb-opt.nexts	2018-10-14 17:18:31.424976480 +0200
            @@ -120,6 +120,7 @@
             a = 3
             n = 0
             t = 0
            +92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
             91:			n += a
             90:			t += i * a
             92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
            @@ -128,6 +129,7 @@
             a = 3
             n = 3
             t = 3
            +92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
             91:			n += a
             90:			t += i * a
             92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
            @@ -141,6 +143,7 @@
             a = 2
             n = 6
             t = 9
            +92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
             91:			n += a
             90:			t += i * a
             92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
            @@ -149,6 +152,7 @@
             a = 1
             n = 8
             t = 17
            +92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
             91:			n += a
             90:			t += i * a
             92:			fmt.Fprintf(os.Stderr, "%d\t%d\t%d\t%d\t%d\n", i, a, n, i*a, t) //gdb-dbg=(n,i,t)
FAIL
exit status 1
FAIL	cmd/compile/internal/ssa	0.450s

Spotted on the longtest builder.

cc @randall77
@ALTree ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 14, 2018
@ALTree ALTree added this to the Go1.12 milestone Oct 14, 2018
@gopherbot
Copy link

Change https://golang.org/cl/141649 mentions this issue: cmd/compile: fix gdb stepping test

@randall77 randall77 self-assigned this Oct 14, 2018
@ALTree
Copy link
Member Author

ALTree commented Oct 15, 2018

The test appears to be still broken:

https://build.golang.org/log/7fd141f67f2945fa7eed97030fc92d8d1e155119

now with a slightly different error message.

@ALTree ALTree reopened this Oct 15, 2018
@randall77
Copy link
Contributor

Wha??? That seems to be the exact opposite of the previous fix I just did.

@gopherbot
Copy link

Change https://golang.org/cl/142298 mentions this issue: cmd/compile: fix gdb stepping test, take 2

@golang golang locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@ALTree @randall77 @gopherbot