Skip to content

x/review: README go get command is wrong #28196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johanbrandhorst opened this issue Oct 14, 2018 · 2 comments
Closed

x/review: README go get command is wrong #28196

johanbrandhorst opened this issue Oct 14, 2018 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@johanbrandhorst
Copy link
Member

The README in the review repo suggests running go get -u golang.org/x/review, but this simply results in package golang.org/x/review: no Go files in $GOPATH/src/golang.org/x/review. Reference: https://github.com/golang/review#downloadinstall.

Running go get -u golang.org/x/review/git-codereview works.
@gopherbot gopherbot added this to the Unreleased milestone Oct 14, 2018
@johanbrandhorst
Copy link
Member Author

I'll get a CL up to correct this.

@johanbrandhorst johanbrandhorst changed the title x/review/git-codereview: README go get command is wrong x/review: README go get command is wrong Oct 14, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/141802 mentions this issue: README.md: correct installation instructions

@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. Documentation Issues describing a change to documentation. labels Oct 14, 2018
@golang golang locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ALTree @johanbrandhorst @gopherbot