Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: add CONNECT bidi example #28178

Open
bradfitz opened this issue Oct 12, 2018 · 6 comments
Open

net/http: add CONNECT bidi example #28178

bradfitz opened this issue Oct 12, 2018 · 6 comments
Labels
Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@bradfitz
Copy link
Contributor

https://go-review.googlesource.com/c/go/+/123156 is removing some documentation from http.Transport that says not to use CONNECT requests with Transport because it's adding CONNECT support.

We should also add examples. CL 123156 has a test which is close at least, but could be cleaned up and be made less unit-testy.
@bradfitz bradfitz added Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Oct 12, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Oct 12, 2018
@bradfitz bradfitz self-assigned this Oct 12, 2018
@fengzixu
Copy link

I would like to handle it. Could you give this issue to me? @bradfitz

@bradfitz
Copy link
Contributor Author

Go for it.

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@odeke-em
Copy link
Member

odeke-em commented Jun 5, 2019

Hello there @fengzixu, thank you for taking on this issue. Might you have some free time in the next week or so to tackle this issue? Or if not, no biggie please let me know and we can send a CL for it. Thank you.

@fengzixu
Copy link

fengzixu commented Jun 5, 2019

@odeke-em Yep. Let me check it and resolve this issue.

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@ToastCheng
Copy link
Contributor

Just noticed this issue has been open for a while, I would like to give it a try 😀

@gopherbot
Copy link

Change https://golang.org/cl/251518 mentions this issue: net/http: add CONNECT example for http.Transport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@bradfitz @rsc @andybons @odeke-em @gopherbot @fengzixu @ToastCheng