Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: missing SOL_TIMESTAMPING_RX_HARDWARE constant(s)? #28173

Closed
xuesongbj opened this issue Oct 12, 2018 · 4 comments
Closed

x/sys/unix: missing SOL_TIMESTAMPING_RX_HARDWARE constant(s)? #28173

xuesongbj opened this issue Oct 12, 2018 · 4 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@xuesongbj
Copy link

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

Go version 1.10.4 linux/amd64

Does this issue reproduce with the latest release?

No(1.10.4)

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/David/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/David/data/go/go.deps:/Users/David/data/go/go.test"
GORACE=""
GOROOT="/Users/David/data/go1.10"
GOTMPDIR=""
GOTOOLDIR="/Users/David/data/go1.10/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches -fno-common"

What did you do?

The system call does not support the SO_TIMESTAMPING setting. Unable to get the socket to return the raw unmodified packet timestamp generated by the hardware.

No SOF_TIMESTAMPING_RX_HARDWARE constant found.

syscall.SetsockoptInt(fd, syscall.SOL_SOCKET, syscall.SOF_TIMESTAMPING_RX_HARDWARE, 1)

What did you expect to see?

Able to support this feature.

What did you see instead?

undefined: syscall.SOF_TIMESTAMPING_RX_HARDWARE
@agnivade
Copy link
Contributor

I can see SO_TIMESTAMPING = 0x25 in https://golang.org/pkg/syscall/#pkg-constants.

Is this not what you want ?

@bradfitz
Copy link
Contributor

The syscall package is frozen.

If we're missing a constant, it can be added to golang.org/x/sys/unix.

/cc @tklauser

@bradfitz bradfitz changed the title Syscall does not support SOL_TIMESTAMPING_RX_HARDWARE settings x/sys/unix: missing SOL_TIMESTAMPING_RX_HARDWARE constant(s)? Oct 13, 2018
@gopherbot gopherbot added this to the Unreleased milestone Oct 13, 2018
@bradfitz bradfitz added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 13, 2018
@xuesongbj
Copy link
Author

Very looking forward to! @bradfitz @tklauser

@gopherbot
Copy link

Change https://golang.org/cl/143337 mentions this issue: unix: add SOF_TIMESTAMPING_* flags on Linux

@golang golang locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @agnivade @gopherbot @xuesongbj