Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: racecompile builder failures on multiple packages #28170

Closed
ALTree opened this issue Oct 12, 2018 · 3 comments
Closed

cmd/compile: racecompile builder failures on multiple packages #28170

ALTree opened this issue Oct 12, 2018 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.12

Comments

@ALTree
Copy link
Member

ALTree commented Oct 12, 2018 •
edited

The racecompile builder has been very flaky for the past two days:

https://build.golang.org/#

failures are reported on many different packages:

https://build.golang.org/log/706e3c506500ddd44b3c7f2a303aff6dc2d415f3
https://build.golang.org/log/68197029863f12197c4d34d1f7eb5a9eec553176
https://build.golang.org/log/eb23684cf4d9315e388a78d84f972daaa1a8b9ee
https://build.golang.org/log/e71a2d04359d9b57b7aa6725ce03edbbcaad9f03

and others. The first failure happened right after https://go-review.googlesource.com/c/go/+/140698 was committed.

cc @randall77
@ALTree ALTree added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Oct 12, 2018
@ALTree ALTree added this to the Go1.12 milestone Oct 12, 2018
@ALTree ALTree changed the title cmd/compile: racecompiler builder failures on multiple packages cmd/compile: racecompile builder failures on multiple packages Oct 12, 2018
@randall77
Copy link
Contributor

Yeah, that could be my CL. I'll look in a bit.
Might also be the cause of #28159, now that I think about it.

@randall77 randall77 self-assigned this Oct 12, 2018
@josharian
Copy link
Contributor

Glancing at that CL on my phone, the only possible suspect I see is init.Append calls; might need addinit instead?

@gopherbot
Copy link

Change https://golang.org/cl/141648 mentions this issue: cmd/compile: emit symbol for constant string before parallel compiler phase

@golang golang locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@josharian @ALTree @randall77 @gopherbot