New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: x/tools broken on FreeBSD by FreeBSD 12 support CL #28131
Comments
Looks like the null termination is broken when converting the FreeBSD 12 structs to the FreeBSD 11 structs. I guess we're lacking test coverage of some system call(s) in std. |
|
Change https://golang.org/cl/141297 mentions this issue: |
Change https://golang.org/cl/141801 mentions this issue: |
…r NULL in parseDirEnt Crossing Dirent.Reclen boundry was manifested in golang/go#28131 as garbaled filenames, when Dirent.Name was not NULL terminated on FreeBSD due to a bug (parseDirEnt would find a NULL in the following Dirent's Fileno/Reclen fields). Only search for NULL on linux, when the Namlen field is available use it directly instead. Updates golang/go#28131 Change-Id: I64090576c8bad2bd246d1561432bf73d5caee2a9 Reviewed-on: https://go-review.googlesource.com/c/141801 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The x/tools subrepo seems to be broken after CL 138595. /cc @paulzhol
See https://build.golang.org/?repo=golang.org%2fx%2ftools#short and https://go-review.googlesource.com/c/go/+/138595#message-71a4da926fb9669d319aa4b34fd9d548de32dc23.
/cc @bradfitz @bcmills @heschik
The text was updated successfully, but these errors were encountered: