Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: FAIL: TestLldbPython #28028

Closed
YoshikiShibata opened this issue Oct 4, 2018 · 4 comments
Closed

runtime: FAIL: TestLldbPython #28028

YoshikiShibata opened this issue Oct 4, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@YoshikiShibata
Copy link

Please answer these questions before submitting your issue. Thanks!

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

Rebuilding the latest tip version with all.bash

What did you expect to see?

No failure.

What did you see instead?

ok  	regexp/syntax	0.798s
--- FAIL: TestLldbPython (1.14s)
    runtime-lldb_test.go:39: bad lldb --version output: lldb-1000.11.37.1
          Swift-4.2
panic: runtime error: index out of range [recovered]
	panic: runtime error: index out of range


goroutine 23021 [running]:
panic(0x129c5c0, 0x1519160)
	/Users/yoshiki/tools/go/src/runtime/panic.go:556 +0x2be fp=0xc0000919c0 sp=0xc000091930 pc=0x102df0e
testing.tRunner.func1(0xc0000c6600)
	/Users/yoshiki/tools/go/src/testing/testing.go:799 +0x378 fp=0xc000091a40 sp=0xc0000919c0 pc=0x10ee618
runtime.call32(0x0, 0x12fda48, 0xc00013e470, 0x800000008)
	/Users/yoshiki/tools/go/src/runtime/asm_amd64.s:522 +0x3b fp=0xc000091a70 sp=0xc000091a40 pc=0x105e50b
panic(0x129c5c0, 0x1519160)
	/Users/yoshiki/tools/go/src/runtime/panic.go:513 +0x1b5 fp=0xc000091b00 sp=0xc000091a70 pc=0x102de05
runtime.panicindex()
	/Users/yoshiki/tools/go/src/runtime/panic.go:44 +0xfa fp=0xc000091b30 sp=0xc000091b00 pc=0x102caaa
runtime_test.checkLldbPython(0xc0000c6600)
	/Users/yoshiki/tools/go/src/runtime/runtime-lldb_test.go:41 +0xbd8 fp=0xc000091d70 sp=0xc000091b30 pc=0x122b328
runtime_test.TestLldbPython(0xc0000c6600)
	/Users/yoshiki/tools/go/src/runtime/runtime-lldb_test.go:166 +0x8c fp=0xc000091fa8 sp=0xc000091d70 pc=0x122b3cc
testing.tRunner(0xc0000c6600, 0x12fd070)
	/Users/yoshiki/tools/go/src/testing/testing.go:834 +0xbf fp=0xc000091fd0 sp=0xc000091fa8 pc=0x10ea61f
runtime.goexit()
	/Users/yoshiki/tools/go/src/runtime/asm_amd64.s:1340 +0x1 fp=0xc000091fd8 sp=0xc000091fd0 pc=0x1060201
created by testing.(*T).Run
	/Users/yoshiki/tools/go/src/testing/testing.go:885 +0x34d

Does this issue reproduce with the latest release (go1.11.1)?

N/A

System details

go version devel +808186203b Thu Oct 4 20:26:13 2018 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/yoshiki/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/yoshiki/gocode:/Users/yoshiki/exercises/gpl:/Users/yoshiki/oak"
GOPROXY=""
GORACE=""
GOROOT="/Users/yoshiki/tools/go"
GOTMPDIR=""
GOTOOLDIR="/Users/yoshiki/tools/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
GOROOT/bin/go version: go version devel +808186203b Thu Oct 4 20:26:13 2018 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +808186203b Thu Oct 4 20:26:13 2018 +0000
uname -v: Darwin Kernel Version 18.0.0: Wed Aug 22 20:13:40 PDT 2018; root:xnu-4903.201.2~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.14
BuildVersion:	18A391
lldb --version: lldb-1000.11.37.1
  Swift-4.2
@mark-rushakoff
Copy link
Contributor

Most likely related to d217004. cc @ALTree

@agnivade
Copy link
Contributor

agnivade commented Oct 5, 2018

Ah, we are parsing the version string by hand. And it doesn't like lldb-1000.11.37.1. We should probably call Fatalf or Skipf instead of Errorf. Because Errorf continues execution which is causing the panic.

@agnivade agnivade added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 5, 2018
@agnivade agnivade added this to the Go1.12 milestone Oct 5, 2018
@ALTree ALTree self-assigned this Oct 5, 2018
@ALTree ALTree added the Testing An issue that has been verified to require only test changes, not just a test failure. label Oct 5, 2018
@gopherbot
Copy link

Change https://golang.org/cl/140217 mentions this issue: Revert "runtime: skip TestLldbPython when lldb is too old"

@ALTree
Copy link
Member

ALTree commented Oct 5, 2018

I'm sorry for breaking all the Darwin builders.

I didn't anticipate the weird version strings on darwin (lldb-1000.11.37.1); I'm not even sure how they correlate with the linux versions (3.8, 3.9, etc..), so for now I'm just reverting the check.

@ALTree ALTree changed the title FAIL: TestLldbPython runtime: FAIL: TestLldbPython Oct 5, 2018
@golang golang locked and limited conversation to collaborators Oct 5, 2019
@rsc rsc unassigned ALTree Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
6 participants
@mark-rushakoff @YoshikiShibata @agnivade @ianlancetaylor @ALTree @gopherbot