Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/importer: remove support for (now defunct) binary export format (reminder issue) #27999

Closed
griesemer opened this issue Oct 3, 2018 · 11 comments
Closed

go/importer: remove support for (now defunct) binary export format (reminder issue) #27999

griesemer opened this issue Oct 3, 2018 · 11 comments
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.15

Comments

@griesemer
Copy link
Contributor

The compiler only generates the new indexed export format, and any support for the old binary export format has been removed.

We can eliminate the support from go/importer as well.

(Before we do, double-check that the latest version of that code is ported to x/tools where it needs to survive for another 3 release cycles - until 1.14.)
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 3, 2018
@griesemer griesemer added this to the Go1.12 milestone Oct 3, 2018
@griesemer griesemer self-assigned this Oct 3, 2018
@gopherbot
Copy link

Change https://golang.org/cl/143023 mentions this issue: go/importer: remove support for defunct binary export format

@gopherbot
Copy link

Change https://golang.org/cl/143024 mentions this issue: go/internal/gcimporter: rename file to better reflect new meaning

@alandonovan
Copy link
Contributor

We can't fix this bug until we've done #28260, otherwise there will be no export data format that go/types can both read and write.

@griesemer
Copy link
Contributor Author

Moving to 1.13 - depends on #28260.

@griesemer griesemer modified the milestones: Go1.12, Go1.13 Dec 5, 2018
@griesemer griesemer modified the milestones: Go1.13, Go1.14 May 6, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@griesemer
Copy link
Contributor Author

#28260 has been fixed.

Verify that we don't need the binary export format anywhere before taking action on this.

cc: @stamblerre

@griesemer griesemer modified the milestones: Backlog, Go1.14 Oct 22, 2019
@griesemer
Copy link
Contributor Author

Moving tentatively to 1.14.

@griesemer griesemer modified the milestones: Go1.14, Go1.15 Nov 12, 2019
@griesemer griesemer added the early-in-cycle A change that should be done early in the 3 month dev cycle. label Nov 12, 2019
@dmitshur
Copy link
Contributor

This issue is currently labeled as early-in-cycle for Go 1.15. That time is now, so friendly ping. If it no longer needs to be done early in cycle, that label can be removed.

@gopherbot
Copy link

Change https://golang.org/cl/220237 mentions this issue: Revert "go/importer: remove support for defunct binary export format"

@bcmills bcmills reopened this Feb 20, 2020
@bcmills
Copy link
Contributor

bcmills commented Feb 20, 2020

This broke current tests in x/tools, so it either needs to be reverted or those tests need to be updated or removed ASAP.

@gopherbot
Copy link

Change https://golang.org/cl/220277 mentions this issue: go/internal/gcimporter: update TestImportedTypes for BImportData removal

gopherbot pushed a commit to golang/tools that referenced this issue Feb 20, 2020
@dmitshur
go/internal/gcimporter: update TestImportedTypes for BImportData removal
2086a0a 
BImportData was removed from the standard library in CL 143023.
Update TestImportedTypes test data to use FindPkg instead.

Updates golang/go#27999.

Change-Id: I8ddb061da31187cc4a3b1c65f2d82d379a6c1066
Reviewed-on: https://go-review.googlesource.com/c/tools/+/220277
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@griesemer
Copy link
Contributor Author

The x/tools breakage has been fixed. Closing again.

@griesemer griesemer mentioned this issue Feb 20, 2020
Closed
gopherbot pushed a commit that referenced this issue Feb 20, 2020
@griesemer
go/internal/gcimporter: rename file to better reflect new meaning
631b498 
Also: Removed unused deref function.

Follow-up on https://golang.org/cl/143023.

Updates #27999.

Change-Id: I088265f0e3ce52029679407f0b84b734191d4d3c
Reviewed-on: https://go-review.googlesource.com/c/go/+/143024
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
6 participants
@rsc @dmitshur @bcmills @alandonovan @griesemer @gopherbot