Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestLookupDotsWithRemoteSource is flaky #27992

Open
katiehockman opened this issue Oct 3, 2018 · 29 comments
Open

net: TestLookupDotsWithRemoteSource is flaky #27992

katiehockman opened this issue Oct 3, 2018 · 29 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@katiehockman
Copy link
Contributor

katiehockman commented Oct 3, 2018

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource" && (`DNS server failure`||`no such host`||`server misbehaving`)

We are getting flaky test failures in net. This has been somewhat rare in the past few months, but it has failed the last 5 builds, so probably worth looking into now.

--- FAIL: TestLookupDotsWithRemoteSource (15.57s)
    lookup_test.go:694: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 8.8.8.8:53: read udp 10.50.0.170:50511->8.8.8.8:53: i/o timeout (mode=go)
FAIL
FAIL	net	30.123s

Looks very related to #16865 closed 2 years ago.

@katiehockman katiehockman added OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure. labels Oct 3, 2018
@katiehockman
Copy link
Contributor Author

/cc @mikioh @brad-burch @ianlancetaylor

@ianlancetaylor
Copy link
Contributor

2018-06-13T18:06:14-537fb06/darwin-amd64-10_10
2018-06-13T18:06:14-537fb06/darwin-amd64-10_11
2018-06-26T16:40:09-8997ec1/darwin-amd64-10_10
2018-06-26T16:40:09-8997ec1/darwin-amd64-10_11
2018-06-26T16:40:09-8997ec1/darwin-amd64-race
2018-07-03T16:14:43-2ee6bfb/darwin-amd64-10_10
2018-07-03T16:14:43-2ee6bfb/darwin-amd64-10_12
2018-07-03T16:27:51-aad71d3/darwin-amd64-10_12
2018-07-03T17:37:40-5d4f047/darwin-386-10_11
2018-07-03T17:37:40-5d4f047/darwin-amd64-10_10
2018-07-03T17:37:40-5d4f047/darwin-amd64-10_11
2018-07-09T22:19:21-94076fe/darwin-amd64-10_10
2018-07-11T01:08:56-5e70b13/darwin-amd64-race
2018-07-27T16:29:52-b39fb9e/darwin-amd64-10_10
2018-08-17T15:34:50-876c6d1/darwin-386-10_11
2018-08-17T15:34:50-876c6d1/darwin-amd64-10_10
2018-08-17T15:34:50-876c6d1/darwin-amd64-10_11
2018-08-21T04:39:22-80fe2e6/darwin-amd64-race
2018-08-21T04:50:21-2a5df06/darwin-386-10_11
2018-08-21T04:55:04-187a41d/darwin-amd64-10_10
2018-08-21T04:55:04-187a41d/darwin-amd64-10_11
2018-08-21T14:08:12-e8daca4/darwin-amd64-10_10
2018-08-22T22:11:24-ccb70bd/darwin-386-10_11
2018-08-24T23:02:01-aacc891/darwin-amd64-10_10
2018-08-24T23:02:31-523dc5a/darwin-amd64-10_10
2018-08-30T19:36:15-a2a8396/darwin-amd64-10_10
2018-08-30T19:36:15-a2a8396/darwin-amd64-race
2018-10-03T15:01:47-c96e3bc/darwin-amd64-10_10
2018-10-03T19:52:49-cbafcc5/darwin-amd64-10_10
2018-10-03T19:54:16-9a8372f/darwin-amd64-10_10
2018-10-03T19:54:29-c91ce3c/darwin-386-10_11
2018-10-03T19:54:29-c91ce3c/darwin-amd64-10_10
2018-10-03T19:54:29-c91ce3c/darwin-amd64-race
2018-10-03T20:13:35-112f28d/darwin-amd64-10_10

@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Oct 3, 2018
@ianlancetaylor
Copy link
Contributor

Any chance there was a recent change to whether the builders set GO_BUILDER_FLAKY_NET in the environment? Because the test does not fail in that way if that environment variable is set.

@katiehockman katiehockman changed the title net: Flaky test failing in darwin-amd64-10_10 net: flaky test failing in darwin-amd64-10_10 Oct 3, 2018
@mikioh
Copy link
Contributor

mikioh commented Oct 3, 2018

Once http://golang.org/cl/102875 lands, I will smash the use of external DNS speakers such as rsc.io or some public full resolver then flaky tests disappear. For now, I have no spare time to debug the circumstances running the tests, also not sure there's a way to sneak in the (protected) circumstances.

@andybons
Copy link
Member

@mikioh should we just disable this test until 1.13?

@mikioh
Copy link
Contributor

mikioh commented Nov 29, 2018

Yes, please. Will try to allocate my spare time for Go 1.13 devel cycle.

@andybons andybons self-assigned this Nov 29, 2018
@gopherbot
Copy link

Change https://golang.org/cl/151799 mentions this issue: net: skip flaky TestLookupDotsWithRemoteSource for now

gopherbot pushed a commit that referenced this issue Nov 30, 2018
Updates #27992

Change-Id: Ic327df7cc5002a3d537f9117559c25f30e1eab9c
Reviewed-on: https://go-review.googlesource.com/c/151799
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons
Copy link
Member

@mikioh done. Assigning back to you. Thanks.

@andybons andybons assigned mikioh and unassigned andybons Nov 30, 2018
@andybons andybons modified the milestones: Go1.12, Go1.13 Nov 30, 2018
@mikioh mikioh removed their assignment Dec 4, 2018
@bcmills bcmills changed the title net: flaky test failing in darwin-amd64-10_10 net: TestLookupDotsWithRemoteSource is flaky May 15, 2019
@bcmills
Copy link
Contributor

bcmills commented May 15, 2019

Here's the same failure mode on dragonfly-amd64: https://build.golang.org/log/2f33b64e758b0fb89431e34f51f80580e5b56e59

--- FAIL: TestLookupDotsWithRemoteSource (10.85s)
    lookup_test.go:669: LookupCNAME(www.mit.edu, mode=go): lookup www.mit.edu on 192.168.1.100:53: read udp 192.168.1.2:54367->192.168.1.100:53: i/o timeout
FAIL
FAIL	net	68.224s

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label May 15, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@bcmills
Copy link
Contributor

bcmills commented Aug 20, 2019

freebsd-arm-paulzhol (https://build.golang.org/log/daa40802f66a0d79d4d356d551c94456f56785b1):

--- FAIL: TestLookupDotsWithRemoteSource (12.52s)
    lookup_test.go:656: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 192.168.1.253:53: read udp 192.168.1.101:38233->192.168.1.253:53: i/o timeout (mode=go)
FAIL
FAIL	net	44.919s

@bcmills bcmills removed the OS-Darwin label Aug 20, 2019
@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
@bcmills
Copy link
Contributor

bcmills commented Jan 27, 2020

I did some digging, and I believe that this flakiness is caused by the hard-coded timeout and attempt limits in net/dnsconfig_unix.go:

conf := &dnsConfig{
ndots: 1,
timeout: 5 * time.Second,
attempts: 2,
}

On my Linux workstation, man 5 resolv.conf reports these same defaults. However, given that the Go net.Resolver API accepts a context.Context which can provide its own timeout behavior, I think these hard-coded limits are out of place: they might make sense in the context of a legacy POSIX C API, but they don't really fit in a modern Go package.

I would recommend:

  1. Complete this TODO to allow the Resolver to override the system-default timeout (and likely also the default limit on attempts).

  2. Refactor the RemoteSource test to use a Resolver and explicit Context instead of the Context-less top-level LookupAddr function. Bound the timeout and number of retries to the test's deadline (testing: add (*T).Deadline #28135) instead of arbitrary constants.

@bcmills
Copy link
Contributor

bcmills commented Dec 3, 2021

@alexbrainman
Copy link
Member

@mknyszek
Copy link
Contributor

mknyszek commented Sep 6, 2022

Another flake:

2022-09-02T06:22:23-ec2ea40/windows-386-2008

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2022-08-02 18:51 windows-386-2008 go@e9d7f54a net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.12s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-08-11 20:03 windows-386-2012 go@72a857a2 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.03s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-08-16 17:18 windows-amd64-2008 go@805305e2 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.08s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-08-18 16:16 windows-amd64-2008 go@b6149224 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.02s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-08-22 18:51 windows-amd64-2016 go@a726c9f6 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.02s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-08-23 22:44 windows-amd64-2008 go@ab8a2c5e net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.04s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-08-31 20:05 windows-386-2008 go@9085ff58 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.04s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-08-31 22:22 windows-amd64-race go@e4b624ea net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.08s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-09-02 02:09 windows-amd64-longtest go@a31c062c net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.11s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-09-08 14:57 windows-amd64-race go@530a2369 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.02s)
    lookup_test.go:662: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-09-08 21:18 windows-amd64-longtest go@e20106ac net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.01s)
    lookup_test.go:662: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)
2022-09-21 01:56 windows-amd64-longtest go@d11c58ee net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.05s)
    lookup_test.go:662: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2022-09-29 14:51 windows-amd64-race go@9861e8b2 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.03s)
    lookup_test.go:662: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2022-11-04 15:03 windows-386-2012 go@edfe0783 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.15s)
    lookup_test.go:663: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2022-11-09 17:33 freebsd-arm64-dmgk go@7a92c4fc net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.20s)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=go)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=cgo)

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2022-11-08 14:52 freebsd-arm64-dmgk go@a1c31d68 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.07s)
    lookup_test.go:706: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=go)
    lookup_test.go:706: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=cgo)
2022-11-09 17:39 aix-ppc64 go@cd8d1bca net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.16s)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 140.211.166.130:53: no such host (mode=go)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 140.211.166.130:53: no such host (mode=cgo)
2022-11-09 17:39 freebsd-arm64-dmgk go@cd8d1bca net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.06s)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=go)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=cgo)
2022-11-09 18:44 freebsd-arm64-dmgk go@9e0b6c11 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.12s)
    lookup_test.go:706: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=go)
    lookup_test.go:706: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=cgo)
2022-11-10 18:18 aix-ppc64 go@fd0c0db4 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.14s)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 140.211.166.130:53: no such host (mode=go)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 140.211.166.130:53: no such host (mode=cgo)
2022-11-10 18:18 freebsd-arm64-dmgk go@fd0c0db4 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.11s)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=go)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 10.0.0.2:53: no such host (mode=cgo)
2022-11-10 18:29 aix-ppc64 go@d931b3b7 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.13s)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 140.211.166.130:53: no such host (mode=go)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 140.211.166.130:53: no such host (mode=cgo)

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2023-01-17 19:56 windows-amd64-race go@354c8fb4 net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (0.05s)
    lookup_test.go:665: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=go)

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2023-04-12 20:54 linux-amd64-longtest-race go@f58c6ccc net.TestLookupDotsWithRemoteSource (log)
--- FAIL: TestLookupDotsWithRemoteSource (10.49s)
    lookup_test.go:666: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:666: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=cgo)
2023/04/12 21:27:45 killing splice client after 5 second shutdown timeout

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource"
2023-05-10 22:43 freebsd-amd64-12_3 go@639957eb net.TestLookupDotsWithRemoteSource (log)
SIGSEGV: segmentation violation
PC=0x8009f9f1c m=0 sigcode=1
signal arrived during cgo execution

rax    0xc2c3
rbx    0x437e
rcx    0xc2c3
rdx    0xffffffffffffffff
rdi    0x0
rsi    0x0
...
	/tmp/workdir/go/src/net/lookup_unix.go:96 +0xa5 fp=0xc00032bd98 sp=0xc00032bd38 pc=0x561325
net.(*Resolver).LookupCNAME(0xc000392310?, {0x6dcc10?, 0x879980?}, {0x685212, 0xb})
	/tmp/workdir/go/src/net/lookup.go:472 +0x2b fp=0xc00032bde0 sp=0xc00032bd98 pc=0x55deeb
net.LookupCNAME(...)
	/tmp/workdir/go/src/net/lookup.go:455
net.testDots(0xc0001df380, {0x682ee0, 0x3})
	/tmp/workdir/go/src/net/lookup_test.go:676 +0x12e fp=0xc00032bef0 sp=0xc00032bde0 pc=0x5b918e
net.TestLookupDotsWithRemoteSource(0xc0001df380)
	/tmp/workdir/go/src/net/lookup_test.go:658 +0x157 fp=0xc00032bf70 sp=0xc00032bef0 pc=0x5b8fb7
testing.tRunner(0xc0001df380, 0x699c48)

watchflakes

@gopherbot

This comment was marked as off-topic.

@mateusz834
Copy link
Member

This test is failing again, now the 8.8.8.8.in-addr.arpa. seems to be broken.

[mateusz@arch ~ ]$ dig @8.8.8.8 8.8.8.8.in-addr.arpa PTR

; <<>> DiG 9.18.20 <<>> @8.8.8.8 8.8.8.8.in-addr.arpa PTR
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 47540
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
; EDE: 0 (Other): ([209.244.0.1] Lame delegation at 8.8.8.in-addr.arpa for 8.8.8.8.in-addr.arpa/ptr)
; EDE: 0 (Other): ([209.244.0.2] Lame delegation at 8.8.8.in-addr.arpa for 8.8.8.8.in-addr.arpa/ptr)
; EDE: 22 (No Reachable Authority): (At delegation 8.8.8.in-addr.arpa for 8.8.8.8.in-addr.arpa/ptr)
;; QUESTION SECTION:
;8.8.8.8.in-addr.arpa.        IN    PTR

;; Query time: 53 msec
;; SERVER: 8.8.8.8#53(8.8.8.8) (UDP)
;; WHEN: Fri Dec 29 20:24:19 CET 2023
;; MSG SIZE  rcvd: 288
[mateusz@arch ~ ]$ dig @1.1.1.1 8.8.8.8.in-addr.arpa PTR

; <<>> DiG 9.18.20 <<>> @1.1.1.1 8.8.8.8.in-addr.arpa PTR
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 41010
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
;; QUESTION SECTION:
;8.8.8.8.in-addr.arpa.        IN    PTR

;; Query time: 13 msec
;; SERVER: 1.1.1.1#53(1.1.1.1) (UDP)
;; WHEN: Fri Dec 29 20:23:12 CET 2023
;; MSG SIZE  rcvd: 49
[mateusz@arch ~ ]$ dig @ns1.google.com 8.8.8.8.in-addr.arpa PTR

; <<>> DiG 9.18.20 <<>> @ns1.google.com 8.8.8.8.in-addr.arpa PTR
; (2 servers found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 45541
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;8.8.8.8.in-addr.arpa.        IN    PTR

;; ANSWER SECTION:
8.8.8.8.in-addr.arpa.    86400    IN    PTR    dns.google.

@prattmic
Copy link
Member

prattmic commented Jan 2, 2024

#64937 (comment) notes that this seems to be fixed, though we're still seeing some failures (probably from cached responses?).

@bcmills
Copy link
Contributor

bcmills commented Jan 2, 2024

I wouldn't say that this is “fixed” so much as “back in remission”.

Ideally the test should be made hermetic, but adding a hermetic DNS server to the Go repo for testing purposes seems like kind of a tough sell too. 😅

@Neustradamus
Copy link

It is an important ticket...

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupDotsWithRemoteSource" && (`DNS server failure`||`no such host`||`server misbehaving`)
2023-12-30 00:23 gotip-linux-386-longtest go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: Temporary failure in name resolution (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.60s)
2023-12-30 00:23 gotip-linux-amd64-longtest go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: Temporary failure in name resolution (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.60s)
2023-12-30 00:23 gotip-linux-amd64-longtest-race go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: Temporary failure in name resolution (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.63s)
2023-12-30 00:23 gotip-openbsd-amd64 go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: no such host (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.44s)
2023-12-30 00:23 gotip-solaris-amd64 go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 129.70.161.2:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: temporary name resolution failure (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.15s)
2023-12-30 00:23 gotip-windows-386 go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.138.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.47s)
2023-12-30 00:23 gotip-windows-amd64 go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.138.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.52s)
2023-12-30 00:23 gotip-windows-amd64-longtest go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.128.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.58s)
2023-12-30 00:23 gotip-windows-amd64-race go@3233542e net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.138.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.39s)
2023-12-30 00:24 gotip-linux-386-longtest go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: Temporary failure in name resolution (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.53s)
2023-12-30 00:24 gotip-linux-amd64-longtest go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: Temporary failure in name resolution (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.59s)
2023-12-30 00:24 gotip-linux-amd64-longtest-race go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: Temporary failure in name resolution (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.66s)
2023-12-30 00:24 gotip-openbsd-amd64 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 169.254.169.254:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: no such host (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.48s)
2023-12-30 00:24 gotip-solaris-amd64 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 129.70.161.2:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: temporary name resolution failure (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.19s)
2023-12-30 00:24 gotip-windows-386 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.138.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.65s)
2023-12-30 00:24 gotip-windows-amd64 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.128.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.64s)
2023-12-30 00:24 gotip-windows-amd64-longtest go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.128.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.63s)
2023-12-30 00:24 gotip-windows-amd64-race go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
=== RUN   TestLookupDotsWithRemoteSource
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8.in-addr.arpa. on 10.138.0.1:53: server misbehaving (mode=go)
    lookup_test.go:664: LookupAddr(8.8.8.8): lookup 8.8.8.8: dnsquery: DNS server failure. (mode=cgo)
--- FAIL: TestLookupDotsWithRemoteSource (0.51s)

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Status: Active
Development

No branches or pull requests