Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc/vfs/zipfs: remove zipfs package #27959

Open
broady opened this issue Oct 2, 2018 · 2 comments
Open

x/tools/godoc/vfs/zipfs: remove zipfs package #27959

broady opened this issue Oct 2, 2018 · 2 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@broady
Copy link
Member

broady commented Oct 2, 2018

Once golang.org/cl/133355 is in, and #27205 is resolved, I don't think we need the zipfs package for godoc anymore.

As far as I know, it was created as a workaround for Google App Engine restrictions on number of files allowed in an app deployment.
@broady broady mentioned this issue Oct 2, 2018
Closed
@dmitshur dmitshur changed the title tools/godoc/vfs/zipfs: remove zipfs package x/tools/godoc/vfs/zipfs: remove zipfs package Oct 2, 2018
@gopherbot gopherbot added this to the Unreleased milestone Oct 2, 2018
@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 2, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Oct 2, 2018

Such a change would affect its users.

Do we have a policy to follow to removing non-internal subrepo packages? How do we decide when to do it? How to do it (perhaps deprecate first, remove after some pre-determined time; or something else)?

@SamWhited
Copy link
Member

SamWhited commented Oct 2, 2018 •
edited

Can we move this to the subrepos? I use this package heavily in several products.

EDIT: higher-up in the subrepos, outside of the godoc tree, that is.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@broady @SamWhited @dmitshur @gopherbot