/cc @jordanrh1

--- FAIL: TestDWARF (7.93s) file_test.go:399: main.main not found --- FAIL: TestImportTableInUnknownSection (0.09s) file_test.go:544: unable to locate required file "atmfd.dll" in search path: exec: "atmfd.dll": executable file not found in %PATH% FAIL FAIL debug/pe 12.391s

I am sure, the fix for this is part of #26148. Leaving for @jordanrh1

Alex

I'll take a look.

@jordanrh1 just a friendly ping. Any updates on this?

Looks like we can just skip that test. I'll send a CL. I don't think windows/arm has that DLL.

Change https://golang.org/cl/139720 mentions this issue: debug/pe: skip a test on windows/arm

Correct, Windows IOT Core does not have atmfd.dll. Thank you for fixing.

TestDWARF is failing because of relocations. The test is expecting the runtime address of main.main to match the link-time address, but this does not hold up with relocatable binaries. You'll get a different address printed from a.exe each time you run it due to ASLR.

@alexbrainman What do you think about having a.exe subtract the module base address from the address of main.main, i.e. print the relative offset of main.main from module start?

@alexbrainman What do you think about having a.exe subtract the module base address from the address of main.main, i.e. print the relative offset of main.main from module start?

Sounds reasonable to me. Would like to send a change?

I am reopening this issues to track TestDWARF failure.

Alex

Change https://golang.org/cl/140158 mentions this issue: debug/pe: fix TestDWARF to work with relocations

I get the same error on Windows 10 x64, Version 1809, Build 17763.134. Does this test need additional packages installed?

--- FAIL: TestImportTableInUnknownSection (0.02s)
    file_test.go:613: unable to locate required file "atmfd.dll" in search path: exec: "atmfd.dll": executable file not found in %PATH%
FAIL
FAIL    debug/pe        5.053s

atmfd.dll is the Adobe Type Manager Font Driver. It may be present in an optional package.
@alexbrainman is there another DLL that would work?

Change https://golang.org/cl/151137 mentions this issue: debug/pe: use kernel32.dll in TestImportTableInUnknownSection

I get the same error on Windows 10 x64, Version 1809, Build 17763.134. Does this test need additional packages installed?

No, you should not need anything specific. I adjusted TestImportTableInUnknownSection in https://go-review.googlesource.com/c/go/+/151137 Can you, please, try it and let me know, if it fixes your problem? Thank you.

@alexbrainman is there another DLL that would work?

Now I realised that kernel32.dll should work too.

Alex

Thanks for your fix. I can confirm that it works on my machine, too.

PS C:\go> git show
commit ed7176e50b44567370d487796c02903a70f1f222 (HEAD)
...

PS C:\go\src> .\all.bat
Building Go cmd/dist using C:\go1.11
Building Go toolchain1 using C:\go1.11.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for windows/amd64.


##### Testing packages.

...
ok      debug/dwarf     1.400s
ok      debug/elf       0.649s
ok      debug/gosym     2.650s
ok      debug/macho     0.860s
ok      debug/pe        4.871s
... 

ALL TESTS PASSED

---
Installed Go for windows/amd64 in C:\go
Installed commands in C:\go\bin

I can confirm that it works on my machine, too.

SGTM. Thanks for checking. I just submitted 151137.

Alex

Change https://golang.org/cl/151477 mentions this issue: debug/pe: correct TestImportTableInUnknownSection error message

Now I realised that kernel32.dll should work too.

@jordanrh1 it looks like windows/arm builder still fails on TestImportTableInUnknownSection

https://build.golang.org/log/e37627b9aa1c02a85c1d9d6ba6123052184cdee0

--- FAIL: TestImportTableInUnknownSection (0.06s)
    file_test.go:610: unable to locate required file "atmfd.dll" in search path: exec: "kernel32.dll": executable file not found in %PATH%
FAIL
FAIL	debug/pe	12.768s

It appears that os/exec.LookPath could not find "kernel32.dll" in the %PATH%. I wonder why? kernel32.dll functions are used by Go in many places. Why it could not be found in the %PATH%? Perhaps os/exec.LookPath is broken? Can you investigate, please.

Thank you.

Alex

With the onecore refactoring effort, kernel32.dll was split into a multitude of other DLLs, two of which are kernelbase.dll and kernel32legacy.dll. kernel32.dll does not exist on onecore editions, except as a virtual entity for backwards compatibility. Some candidate DLLs that exist across all flavors of windows are combase.dll, cfgmgr32.dll, and ws2_32.dll.

Change https://golang.org/cl/151480 mentions this issue: debug/pe: use ws2_32.dll in TestImportTableInUnknownSection

Some candidate DLLs that exist across all flavors of windows are combase.dll, cfgmgr32.dll, and ws2_32.dll.

ws2_32.dll works for me. Please, try https://go-review.googlesource.com/c/go/+/151480

Thank you.

Alex

Verified that it works on ARM.

>pe.test.exe -test.v -test.run TestImportTableInUnknownSection
=== RUN   TestImportTableInUnknownSection
--- PASS: TestImportTableInUnknownSection (0.05s)
PASS

Verified that it works on ARM.

Thanks for checking. Just submitted CL 151480.

Alex