Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/analysistest: TestTheTest fails on Darwin and Windows #27877

Closed
andybons opened this issue Sep 26, 2018 · 4 comments
Closed

x/tools/go/analysis/analysistest: TestTheTest fails on Darwin and Windows #27877

andybons opened this issue Sep 26, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin OS-Windows Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.12

Comments

@andybons
Copy link
Member

andybons commented Sep 26, 2018 •
edited

See https://build.golang.org/?repo=golang.org%2fx%2ftools

$ go test ./go/analysis/...
?   	golang.org/x/tools/go/analysis	[no test files]
--- FAIL: TestTheTest (0.11s)
    analysistest_test.go:44: got:
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:8:10: in 'want' comment: invalid syntax
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:5:9: diagnostic "call of println(...)" does not match pattern "wrong expectation text"
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:6:9: unexpected diagnostic: call of println(...)
        /var/folders/bd/jtwcfv9n0fv0bh7t4cdmgf3r0000gn/T/analysistest792496737/src/a/b.go:7: expected diagnostic matching "unsatisfied expectation"
        want:
        a/b.go:8:10: in 'want' comment: invalid syntax
        a/b.go:5:9: diagnostic "call of println(...)" does not match pattern "wrong expectation text"
        a/b.go:6:9: unexpected diagnostic: call of println(...)
        a/b.go:7: expected diagnostic matching "unsatisfied expectation"
FAIL
FAIL	golang.org/x/tools/go/analysis/analysistest	0.119s
@andybons andybons added OS-Darwin NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Sep 26, 2018
@andybons andybons added this to the Go1.11.1 milestone Sep 26, 2018
@andybons andybons changed the title x/tools/go/analysis/analysistest: TestTheTest fails on Darwin x/tools/go/analysis/analysistest: TestTheTest fails on Darwin and Windows Sep 26, 2018
@andybons andybons modified the milestones: Go1.11.1, Go1.12 Sep 26, 2018
@gopherbot
Copy link

Change https://golang.org/cl/137735 mentions this issue: go/analysis/analysistest/analysistest: fix test on non-Linux

@andybons andybons reopened this Sep 27, 2018
@andybons
Copy link
Member Author

Still fails on Windows.

@andybons
Copy link
Member Author

Hm. Odd. The windows builders seem fine. Leaving to Alan to close if actually still failing on Win.

@dmitshur
Copy link
Contributor

dmitshur commented Nov 1, 2018

The windows builders seem fine. Leaving to Alan to close if actually still failing on Win.

I'll close because this seems solved (and has the Soon label). Only s390x has failures, and they're in a different package. Alan, please re-open otherwise.

@dmitshur dmitshur closed this as completed Nov 1, 2018
@golang golang locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin OS-Windows Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@andybons @dmitshur @alandonovan @gopherbot