Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: http://farmer.golang.org should redirect to https #27870

Closed
dmitshur opened this issue Sep 26, 2018 · 5 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge Security
Milestone

Comments

@dmitshur
Copy link
Contributor

Unless there's a good reason why it doesn't/cannot, or it's extremely time-consuming.

build.golang.org, dev.golang.org, tip.golang.org, etc., already do it.

I'd also like to learn how to do this (so I can apply the knowledge in similar situations in the future). /cc @bradfitz

@dmitshur dmitshur added Security Builders x/build issues (builders, bots, dashboards) FeatureRequest labels Sep 26, 2018
@gopherbot gopherbot added this to the Unreleased milestone Sep 26, 2018
@bradfitz
Copy link
Contributor

Sounds fine.

I had said no in the past when we did a bunch of the other service redirects because I didn't 100% trust the autocert code/cert caching and I didn't want to add more moving parts that might fail & hinder debugging of a production system, but I think it's time. Since I last said no, the reverse buildlets now connect to https anyway without using a hard-coded server cert like they used to, so we're already depending on LetsEncrypt/etc.

@bradfitz
Copy link
Contributor

@dmitshur, did you want to do this?

@dmitshur
Copy link
Contributor Author

Sure. This part still applies:

I'd also like to learn how to do this (so I can apply the knowledge in similar situations in the future).

@bradfitz
Copy link
Contributor

There's no config file if that's what you're asking. You just need to go add a few lines of code to a Handler somewhere, checking to see if req.TLS == nil.

@gopherbot
Copy link

Change https://golang.org/cl/168138 mentions this issue: cmd/coordinator: redirect from http to https in production

@golang golang locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge Security
Projects
None yet
Development

No branches or pull requests

3 participants