Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect: MethodByName().Interface() leads to fatal error: sweep increased allocation count [1.10 backport] #27866

Closed
gopherbot opened this issue Sep 25, 2018 · 8 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@gopherbot
Copy link

@randall77 requested issue #27695 to be considered for backport to the next 1.10 minor release.

@gopherbot, please open a backport issue please.

This has been broken for a while, but it's a nasty bug. We should consider backporting it.

@gopherbot
Copy link
Author

Change https://golang.org/cl/138586 mentions this issue: [release-branch.go1.10] reflect: fix s390x reflect method calls

@gopherbot
Copy link
Author

Change https://golang.org/cl/138585 mentions this issue: [release-branch.go1.10] reflect: ensure correct scanning of return values

@gopherbot
Copy link
Author

Change https://golang.org/cl/138584 mentions this issue: [release-branch.go1.10] reflect: use correct write barrier operations for method funcs

@gopherbot
Copy link
Author

Change https://golang.org/cl/138587 mentions this issue: [release-branch.go1.10] runtime: don't dereference 0-length bitvectors

@dmitshur
Copy link
Contributor

dmitshur commented Nov 1, 2018

@randall77 This patch does not apply cleanly to release-branch.go1.10 right now. If you still think this should be backported, can you please make a cherry-pick CL as described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls?

We can also decide this doesn't meet the backport policy criteria, since there is a workaround (update to Go 1.11.1, where this issue is resolved).

Edit: I'll move the milestone to Go 1.10.6 since it's too late for Go 1.10.5 release that's happening today.

@dmitshur dmitshur modified the milestones: Go1.10.5, Go1.10.6 Nov 1, 2018
@gopherbot
Copy link
Author

Change https://golang.org/cl/147237 mentions this issue: [release-branch.go1.10] reflect: ensure correct scanning of return values

@bcmills
Copy link
Contributor

bcmills commented Nov 19, 2018

@randall77, given the fix in 1.11 and the proximity to 1.12, is this still worth backporting to 1.10?

@andybons andybons added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 26, 2018
@dmitshur dmitshur modified the milestones: Go1.10.6, Go1.10.7 Dec 13, 2018
@FiloSottile
Copy link
Contributor

This fix is backported to 1.11, and then upgrading to 1.11 will be a valid workaround, so this is not eligible for backport to 1.10.

@golang golang locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

5 participants