Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestClosedPipeRaceWrite broken on solaris / SmartOS #27861

Closed
bradfitz opened this issue Sep 25, 2018 · 3 comments
Closed

os: TestClosedPipeRaceWrite broken on solaris / SmartOS #27861

bradfitz opened this issue Sep 25, 2018 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Milestone
Go1.12

Comments

@bradfitz
Copy link
Contributor

Just noticed that the solaris-amd64-smartosbuildlet builder is all red. It's probably been red for a long time.

https://build.golang.org/log/6a1342d069021b0cc0a00344eb1373b13d2a760f

--- FAIL: TestClosedPipeRaceWrite (0.00s)
    pipe_test.go:140: using pipe write limit of 65537
    pipe_test.go:176: I/O on closed pipe unexpectedly succeeded
panic: Fail in goroutine after TestClosedPipeRaceWrite has completed

goroutine 220 [running]:
testing.(*common).Fail(0xc0002b0a00)
	/tmp/workdir/go/src/testing/testing.go:553 +0x132
testing.(*common).Error(0xc0002b0a00, 0xc0005d27a0, 0x1, 0x1)
	/tmp/workdir/go/src/testing/testing.go:623 +0x6f
os_test.testClosedPipeRace.func1(0xc0005c0100, 0xc0005c0140, 0xc0005c0148, 0xc0002b0a00)
	/tmp/workdir/go/src/os/pipe_test.go:165 +0x98
created by os_test.testClosedPipeRace
	/tmp/workdir/go/src/os/pipe_test.go:152 +0x15c
FAIL	os	0.545s
@bradfitz bradfitz added help wanted OS-Solaris NeedsFix The path to resolution is known, but the work has not been done. labels Sep 25, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Sep 25, 2018
@bradfitz
Copy link
Contributor Author

I suspect there are just spinning processes in the background.

That builder isn't created & destroyed per build (in either a container or VM). It's just a process running in a loop.

/cc @dmitshur

@tklauser
Copy link
Member

Also see #27566

@bradfitz
Copy link
Contributor Author

Ah, thanks. Closing this as duplicate of #27566.

@golang golang locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@bradfitz @tklauser @gopherbot