Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: fixedbugs/issue7921.go failing on noopt builder #27833

Closed
ALTree opened this issue Sep 24, 2018 · 4 comments
Closed

cmd/compile: fixedbugs/issue7921.go failing on noopt builder #27833

ALTree opened this issue Sep 24, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@ALTree
Copy link
Member

ALTree commented Sep 24, 2018 •
edited

The fixedbugs/issue7921.go test is currently failing on the noopt builder. To reproduce the failure:

$ gotip install -a -gcflags="-N -l" std
$ cd test
$ gotip run run.go -- fixedbugs/issue7921.go
# go run run.go -- fixedbugs/issue7921.go

issue7921.go:21: missing error "inlining call"
issue7921.go:21: missing error "string\\(bytes\\.b\\.buf\\[bytes.b.off:\\]\\) escapes to heap"
issue7921.go:25: no match for `inlining call` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:25: no match for `make\(\[\]byte, 0, 64\) does not escape` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:25: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:29: missing error "inlining call"
issue7921.go:33: no match for `inlining call` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:33: no match for `make\(\[\]byte, 0, 64\) does not escape` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:33: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:38: missing error "inlining call"
issue7921.go:38: missing error "string\\(bytes.b.buf\\[bytes\\.b\\.off:\\]\\) escapes to heap"
issue7921.go:45: no match for `inlining call` in:
	issue7921.go:45: bufferNoEscape4 b does not escape
issue7921.go:49: no match for `inlining call` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
issue7921.go:49: no match for `make\(\[\]byte, 0, 128\) does not escape` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
issue7921.go:49: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
Unmatched Errors:
issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:49: make([]byte, 0, 128) escapes to heap

FAIL	fixedbugs/issue7921.go	0.013s
exit status 1

https://build.golang.org/log/7a86ac7b3725a69c8bed216053356629c79141d3
@ALTree ALTree added this to the Go1.12 milestone Sep 24, 2018
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 24, 2018
@ALTree
Copy link
Member Author

ALTree commented Sep 24, 2018

It's likely that this was broken from the start on the noopt builder. The test was added ~2 weeks ago, but at the time the noopt builder was already broken (for other reasons), so the commiter didn't notice that their test was failing on noopt.

@ALTree ALTree mentioned this issue Sep 24, 2018
Closed
@randall77
Copy link
Contributor

We probably want to just skip "errorcheck -m" tests if "-N" (and/or "-l") is in GO_GCFLAGS.

@bradfitz
Copy link
Contributor

@randall77, on its way.

@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 24, 2018
@gopherbot
Copy link

Change https://golang.org/cl/136898 mentions this issue: test: skip some tests on noopt builder

@randall77 randall77 mentioned this issue Nov 26, 2018
Closed
@golang golang locked and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@bradfitz @ALTree @randall77 @gopherbot