Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/rpc: data race in BenchmarkEndToEnd #2781

Closed
dvyukov opened this issue Jan 25, 2012 · 2 comments
Closed

net/rpc: data race in BenchmarkEndToEnd #2781

dvyukov opened this issue Jan 25, 2012 · 2 comments
Milestone

Comments

@dvyukov
Copy link
Member

dvyukov commented Jan 25, 2012

pkg/net/rpc$ gotest -bench=.* under ThreadSanitizer
(http://code.google.com/p/data-race-test/wiki/ThreadSanitizerGo) outputs the following
error:

WARNING: Possible data race during write of size 1 at 0xf840090860: {{{
   T1520 (L{}):
    #0  net/rpc._func_003 src/pkg/net/rpc/server_test.go:521
    #1  runtime.goexit src/pkg/runtime/proc.c:266
  Concurrent write(s) happened at (OR AFTER) these points:
   T1519 (L{}):
    #0  net/rpc._func_003 src/pkg/net/rpc/server_test.go:521
    #1  runtime.goexit src/pkg/runtime/proc.c:266
  Location 0xf840090860 is 0 bytes inside a block starting at 0xf840090860 of size 16 allocated by T1511 from heap:
    #0  net/rpc.benchmarkEndToEnd src/pkg/net/rpc/server_test.go:504
    #1  net/rpc.BenchmarkEndToEnd src/pkg/net/rpc/server_test.go:583
    #2  testing..runN src/pkg/testing/benchmark.go:84
    #3  testing..launch src/pkg/testing/benchmark.go:169
    #4  runtime.goexit src/pkg/runtime/proc.c:266
}}}

11428:f10dfb8fa0eb tip
@rsc
Copy link
Contributor

rsc commented Jan 25, 2012

Comment 1:

Labels changed: added priority-go1, removed priority-triage.

@dvyukov
Copy link
Member Author

dvyukov commented Jan 26, 2012

Comment 2:

This issue was closed by revision 290921b.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants