Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: clean mod cache should respect "-n" option. #27710

Closed
wants to merge 4 commits into from
Closed

clean: clean mod cache should respect "-n" option. #27710

wants to merge 4 commits into from

Conversation

xiaoxubeii
Copy link
Contributor

Clean mod cache should print remove commands and not run them when with set "-n" option.
Fixes #27458.

@xiaoxubeii
clean: clean mod cache should respect "-n" option.
d4ba617 
Clean mod cache should print remove commands and not run them when with set "-n" option.
Fixes golang#27458.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 17, 2018
@gopherbot
Copy link

This PR (HEAD: d4ba617) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/135695 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gerrit User 6365:

Patch Set 1: Run-TryBot+1 Code-Review+1

(1 comment)

A test would be nice.

(They're pretty easy to add in src/cmd/go/testdata/script: you should be able to use go mod download and the exists script command to test it without actually building anything.)

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=c4e6bdee

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 3730903) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/135695 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 7e00a13) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/135695 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gerrit User 29030:

Patch Set 3:

Patch Set 1: Run-TryBot+1 Code-Review+1

(1 comment)

A test would be nice.

(They're pretty easy to add in src/cmd/go/testdata/script: you should be able to use go mod download and the exists script command to test it without actually building anything.)

I have fixed these. Please review. Thanks :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 6365:

Patch Set 3: Run-TryBot+1 Code-Review+1

Patch Set 3:

Patch Set 1: Run-TryBot+1 Code-Review+1

(1 comment)

A test would be nice.

(They're pretty easy to add in src/cmd/go/testdata/script: you should be able to use go mod download and the exists script command to test it without actually building anything.)

I have fixed these. Please review. Thanks :)

Nice test!

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=96a01e00

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 3:

Build is still in progress...
This change failed on windows-386-2008:
See https://storage.googleapis.com/go-build-log/96a01e00/windows-386-2008_b3e4c1c2.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 3: TryBot-Result-1

2 of 19 TryBots failed:
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/96a01e00/windows-386-2008_b3e4c1c2.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/96a01e00/windows-amd64-2016_f63c41c9.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 6365:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 5a6f10c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/135695 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gerrit User 6365:

Patch Set 4: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f8b23900

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 6365:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 19, 2018
@xiaoxubeii
clean: clean mod cache should respect "-n" option.
f40dc5c 
Clean mod cache should print remove commands and not run them when with set "-n" option.
Fixes #27458.

Change-Id: I97242cb40c062b347784cdb61653c84a3a7eab44
GitHub-Last-Rev: 5a6f10c
GitHub-Pull-Request: #27710
Reviewed-on: https://go-review.googlesource.com/135695
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@gopherbot
Copy link

Message from Gerrit User 6365:

Patch Set 4:

Thanks for the fix!

Please don’t reply on this GitHub thread. Visit golang.org/cl/135695.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/135695 has been merged.

@gopherbot gopherbot closed this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaoxubeii @gopherbot @googlebot