cmd/go: `go test -c` does not respect gcflags sometimes #27681

aarzilli · 2018-09-14T12:29:32Z

What version of Go are you using (`go version`)?

go version go1.11 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/a/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/a/n/go/"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build874739252=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go get github.com/aarzilli/testflags
cd $GOPATH/src/github.com/aarzilli/testflags
go test -c -gcflags 'all=-N -l'
objdump --dwarf testflags.test | grep -A 7 'DW_TAG_compile_unit' | grep 'DW_AT_name\|DW_AT_producer'

What did you expect to see?

All packages except runtime compiled with -N -l

What did you see instead?

    DW_AT_name         DW_FORM_string
    DW_AT_producer     DW_FORM_string
    <c>   DW_AT_name        : sync/atomic
    <2b>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <2efb0>   DW_AT_name        : internal/cpu
    <2efd0>   DW_AT_producer    : Go cmd/compile go1.11; -l
    <2f794>   DW_AT_name        : runtime/internal/sys
    <2f7bc>   DW_AT_producer    : Go cmd/compile go1.11; -l
    <300dc>   DW_AT_name        : runtime/internal/atomic
    <30107>   DW_AT_producer    : Go cmd/compile go1.11; -l
    <3024f>   DW_AT_name        : internal/bytealg
    <30273>   DW_AT_producer    : Go cmd/compile go1.11; -l
    <30732>   DW_AT_name        : runtime
    <3074d>   DW_AT_producer    : Go cmd/compile go1.11; -l
    <593d5>   DW_AT_name        : errors
    <593ef>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <594a7>   DW_AT_name        : internal/race
    <594c8>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <5955b>   DW_AT_name        : sync
    <59573>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <5a287>   DW_AT_name        : io
    <5a29d>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <5a67e>   DW_AT_name        : syscall
    <5a699>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <67e76>   DW_AT_name        : os
    <67e8c>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <6987c>   DW_AT_name        : internal/testlog
    <698a0>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <69a07>   DW_AT_name        : time
    <69a1f>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <6c810>   DW_AT_name        : internal/poll
    <6c831>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <6da1d>   DW_AT_name        : internal/syscall/unix
    <6da46>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <6db96>   DW_AT_name        : math
    <6dbae>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <6df47>   DW_AT_name        : math/bits
    <6df64>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <6e166>   DW_AT_name        : unicode/utf8
    <6e186>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <6eaa3>   DW_AT_name        : strconv
    <6eabe>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <721ee>   DW_AT_name        : unicode
    <72209>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <729bb>   DW_AT_name        : reflect
    <729d6>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <823d8>   DW_AT_name        : fmt
    <823ef>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <843c7>   DW_AT_name        : sort
    <843df>   DW_AT_producer    : Go cmd/compile go1.11
    <84e93>   DW_AT_name        : strings
    <84eae>   DW_AT_producer    : Go cmd/compile go1.11
    <85d64>   DW_AT_name        : flag
    <85d7c>   DW_AT_producer    : Go cmd/compile go1.11
    <8762a>   DW_AT_name        : testing
    <87645>   DW_AT_producer    : Go cmd/compile go1.11
    <8a141>   DW_AT_name        : bytes
    <8a15a>   DW_AT_producer    : Go cmd/compile go1.11
    <8ae44>   DW_AT_name        : runtime/debug
    <8ae65>   DW_AT_producer    : Go cmd/compile go1.11
    <8aeb4>   DW_AT_name        : context
    <8aecf>   DW_AT_producer    : Go cmd/compile go1.11
    <8af8c>   DW_AT_name        : runtime/trace
    <8afad>   DW_AT_producer    : Go cmd/compile go1.11
    <8b137>   DW_AT_name        : bufio
    <8b150>   DW_AT_producer    : Go cmd/compile go1.11
    <8b586>   DW_AT_name        : regexp/syntax
    <8b5a7>   DW_AT_producer    : Go cmd/compile go1.11
    <9042c>   DW_AT_name        : regexp
    <90446>   DW_AT_producer    : Go cmd/compile go1.11
    <92c2b>   DW_AT_name        : encoding/binary
    <92c4e>   DW_AT_producer    : Go cmd/compile go1.11
    <937a6>   DW_AT_name        : text/tabwriter
    <937c8>   DW_AT_producer    : Go cmd/compile go1.11
    <94380>   DW_AT_name        : compress/flate
    <943a2>   DW_AT_producer    : Go cmd/compile go1.11
    <97961>   DW_AT_name        : hash
    <97979>   DW_AT_producer    : Go cmd/compile go1.11
    <979bf>   DW_AT_name        : hash/crc32
    <979dd>   DW_AT_producer    : Go cmd/compile go1.11
    <97f88>   DW_AT_name        : compress/gzip
    <97fa9>   DW_AT_producer    : Go cmd/compile go1.11
    <9858d>   DW_AT_name        : path/filepath
    <985ae>   DW_AT_producer    : Go cmd/compile go1.11
    <9863d>   DW_AT_name        : io/ioutil
    <9865a>   DW_AT_producer    : Go cmd/compile go1.11
    <9885f>   DW_AT_name        : runtime/pprof
    <98880>   DW_AT_producer    : Go cmd/compile go1.11
    <9c2d2>   DW_AT_name        : testing/internal/testdeps
    <9c2ff>   DW_AT_producer    : Go cmd/compile go1.11
    <9cbca>   DW_AT_name        : github.com/aarzilli/testflags
    <9cbfb>   DW_AT_producer    : Go cmd/compile go1.11; -N -l
    <9ccf0>   DW_AT_name        : main
    <9cd08>   DW_AT_producer    : Go cmd/compile go1.11; -N -l

It's pretty weird that it only gets applied to some packages.

The text was updated successfully, but these errors were encountered:

aarzilli · 2018-09-19T10:28:03Z

This is a regression, it used to work in 1.10, and bisects to 2ce6da0

gopherbot · 2018-09-19T12:46:21Z

Change https://golang.org/cl/136275 mentions this issue: cmd/go: respect gcflags, ldflags in 'go test'

jared2501 · 2018-10-24T03:28:39Z

Just ran into this issue - any chance we could get a fix as a patch to 1.11?

ianlancetaylor · 2018-10-24T04:14:24Z

As far as I can see, this hasn't been fixed on tip yet. CC @bcmills

@gopherbot please open a backport to 1.11

gopherbot · 2018-10-24T04:14:28Z

Backport issue(s) opened: #28346 (for 1.11).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

jared2501 · 2018-10-24T05:09:43Z

Thanks Ian!

heschi · 2018-11-20T20:04:19Z

This is pretty bad for the debugging experience when it hits. Marking as a release blocker; feel free to undo it if I'm overstating things.

bcmills · 2018-12-21T14:37:30Z

I believe @jayconrod is looking in to this.

webern · 2018-12-31T18:56:14Z

I cannot tell from the Github issues what patch version of go1.11 the backport resolution of this issue is slated for. I would like to know when this will be/is fixed.

ianlancetaylor · 2018-12-31T21:30:46Z

@webern This is not yet fixed in any version of Go. It has to be fixed on tip first, then we can consider when it will be backported to 1.11.

FiloSottile · 2019-01-02T19:34:05Z

@jayconrod @aarzilli We are planning on cutting RC1 this week, do you think you can get the fix submitted between today and tomorrow?

jayconrod · 2019-01-02T22:38:57Z

@FiloSottile We just need a small change in that CL, then it's ready to go. If the change isn't in by tomorrow morning, we can submit as-is, and I can submit a quick follow-up CL.

webern · 2019-01-03T20:10:42Z

So is the fix in go1.12beta1 on this page (https://golang.org/dl/)?
Thanks.

aarzilli · 2019-01-03T20:13:43Z

@webern no, 1.12beta1 was cut two weeks ago and this fix was merged 3 hours ago.

jayconrod · 2019-01-03T20:21:26Z

@webern This will be in RC1 which will cut soon.

gopherbot · 2019-01-04T18:23:57Z

Change https://golang.org/cl/156377 mentions this issue: [release-branch.go1.11] cmd/go: respect gcflags, ldflags in 'go test'

katiehockman · 2019-01-07T20:53:57Z

For bookkeeping, this is another CL that was related to this issue: https://golang.org/cl/156327

ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 14, 2018

ianlancetaylor added this to the Go1.12 milestone Sep 14, 2018

bcmills mentioned this issue Sep 17, 2018

cmd/go: '-gcflags=all=-l' flag does not disable inlining for all packages #27708

Closed

aarzilli mentioned this issue Oct 11, 2018

Unreadable arguments and "debugging optimized function" warning go-delve/delve#1368

Closed

gopherbot mentioned this issue Oct 24, 2018

cmd/go: go test -c does not respect gcflags sometimes [1.11 backport] #28346

Closed

bcmills mentioned this issue Nov 15, 2018

cmd/go: setting a global "-trimpath" untrims some temporary cgo files #24976

Closed

heschi added the Debugging label Nov 19, 2018

heschi added the release-blocker label Nov 20, 2018

jayconrod self-assigned this Dec 21, 2018

gopherbot closed this as completed in 374546d Jan 3, 2019

aarzilli mentioned this issue Jan 23, 2019

could not find symbol value for err1 go-delve/delve#1468

Closed

tirodactyl mentioned this issue Jan 30, 2019

Case-insensitive query results differ when run through DB.batchFetch samsarahq/thunder#220

Open

golang locked and limited conversation to collaborators Jan 7, 2020

gopherbot added the FrozenDueToAge label Jan 7, 2020

rsc unassigned jayconrod Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/go: `go test -c` does not respect gcflags sometimes #27681

cmd/go: `go test -c` does not respect gcflags sometimes #27681

aarzilli commented Sep 14, 2018

aarzilli commented Sep 19, 2018

gopherbot commented Sep 19, 2018

jared2501 commented Oct 24, 2018

ianlancetaylor commented Oct 24, 2018

gopherbot commented Oct 24, 2018

jared2501 commented Oct 24, 2018

heschi commented Nov 20, 2018

bcmills commented Dec 21, 2018

webern commented Dec 31, 2018

ianlancetaylor commented Dec 31, 2018

FiloSottile commented Jan 2, 2019

jayconrod commented Jan 2, 2019

webern commented Jan 3, 2019

aarzilli commented Jan 3, 2019

jayconrod commented Jan 3, 2019

gopherbot commented Jan 4, 2019

katiehockman commented Jan 7, 2019 •

edited

cmd/go: go test -c does not respect gcflags sometimes #27681

cmd/go: go test -c does not respect gcflags sometimes #27681

Comments

aarzilli commented Sep 14, 2018

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

aarzilli commented Sep 19, 2018

gopherbot commented Sep 19, 2018

jared2501 commented Oct 24, 2018

ianlancetaylor commented Oct 24, 2018

gopherbot commented Oct 24, 2018

jared2501 commented Oct 24, 2018

heschi commented Nov 20, 2018

bcmills commented Dec 21, 2018

webern commented Dec 31, 2018

ianlancetaylor commented Dec 31, 2018

FiloSottile commented Jan 2, 2019

jayconrod commented Jan 2, 2019

webern commented Jan 3, 2019

aarzilli commented Jan 3, 2019

jayconrod commented Jan 3, 2019

gopherbot commented Jan 4, 2019

katiehockman commented Jan 7, 2019 • edited

cmd/go: `go test -c` does not respect gcflags sometimes #27681

cmd/go: `go test -c` does not respect gcflags sometimes #27681

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

katiehockman commented Jan 7, 2019 •

edited