Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc: type Cookie (net/http) doesn't generate a header #27674

Closed
nickkeets opened this issue Sep 14, 2018 · 2 comments
Closed

x/tools/godoc: type Cookie (net/http) doesn't generate a header #27674

nickkeets opened this issue Sep 14, 2018 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@nickkeets
Copy link

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.11 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

darwin, amd64

What did you do?

  1. Go to: https://tip.golang.org/pkg/net/http/
  2. Click on the index link for type Cookie: https://tip.golang.org/pkg/net/http/#Cookie

What did you expect to see?

Go down to the anchor point for type Cookie

What did you see instead?

Link doesn't work and if you manually scroll down to find it, there is no header generated.

This doesn't seem to be a problem with the doc comment itself. If I change the type name (and respectively the doc comment) to something else (e.g. Cookie2), godoc works.
@gopherbot gopherbot added this to the Unreleased milestone Sep 14, 2018
@agnivade
Copy link
Contributor

Works for me. When you say "there is no header generated", do you mean you are not seeing the type Cookie in a light blue background at all ?

@agnivade agnivade added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 14, 2018
@nickkeets
Copy link
Author

Yes, the blue background would not generate at all and thus the anchor would not work at all. It didn't occur to me that it would be a browser issue, but after your comment I investigated more and realized that this was caused by uBlock origin on my browser!

Apologies for the noise.

@golang golang locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@agnivade @gopherbot @nickkeets