You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When processing an xtest that depends on packages that themselves depend on the package under test, they all need to be substituted with special test versions.
go list does this correctly in 1.11, but the 1.10 fallback code does not. gopackages -mode Syntax -test debug/dwarf
with 1.10 produces
Go package "debug/dwarf_test [debug/dwarf.test]":
package dwarf_test
has complete exported type info and typed ASTs
file /usr/lib/go/src/debug/dwarf/entry_test.go
file /usr/lib/go/src/debug/dwarf/line_test.go
file /usr/lib/go/src/debug/dwarf/type_test.go
import "debug/dwarf" => "debug/dwarf [debug/dwarf.test]"
import "debug/elf"
import "debug/macho"
import "debug/pe"
import "io"
import "reflect"
import "strings"
import "testing"
/usr/lib/go/src/debug/dwarf/type_test.go:55:9: cannot use d (variable of type *debug/dwarf.Data) as *debug/dwarf.Data value in return statement
/usr/lib/go/src/debug/dwarf/type_test.go:68:9: cannot use d (variable of type *debug/dwarf.Data) as *debug/dwarf.Data value in return statement
/usr/lib/go/src/debug/dwarf/type_test.go:81:9: cannot use d (variable of type *debug/dwarf.Data) as *debug/dwarf.Data value in return statement
whereas in 1.11 the imports are
Go package "debug/dwarf_test [debug/dwarf.test]":
package dwarf_test
has complete exported type info and typed ASTs
file /Users/iancottrell/sdk/go1.11/src/debug/dwarf/entry_test.go
file /Users/iancottrell/sdk/go1.11/src/debug/dwarf/line_test.go
file /Users/iancottrell/sdk/go1.11/src/debug/dwarf/type_test.go
import "debug/dwarf" => "debug/dwarf [debug/dwarf.test]"
import "debug/elf" => "debug/elf [debug/dwarf.test]"
import "debug/macho" => "debug/macho [debug/dwarf.test]"
import "debug/pe" => "debug/pe [debug/dwarf.test]"
import "io"
import "reflect"
import "strings"
import "testing"
The text was updated successfully, but these errors were encountered:
When processing an xtest that depends on packages that themselves depend on the package under test, they all need to be substituted with special test versions.
go list does this correctly in 1.11, but the 1.10 fallback code does not.
gopackages -mode Syntax -test debug/dwarf
with 1.10 produces
whereas in 1.11 the imports are
The text was updated successfully, but these errors were encountered: