cmd/go: go list -m -u -json all does not produce valid JSON #27655
Labels
Milestone
Comments
bcmills
added
modules
NeedsFix
|
@przglo You can easily use the following approach to parse the output (which does wait for all of the output; the alternative would be to connect the stdout of the command to the decoder): type Module struct {
// ...
}
// ...
out, err := exec.Command("go", "list", "-m", "all").Output()
// ...
dec := json.NewDecoder(bytes.NewReader(out))
for {
var m Module
if err := dec.Decode(&m); err != nil {
if err == io.EOF {
break
}
log.Fatalf("reading go list output: %v", err)
}
// do something with m
} |
|
This is indeed working as intended. It's a stream of JSON objects, which is easy to parse with encoding/json (as @myitcv demonstrates). Besides, this isn't going to be changed now, tools are depending on the existing format. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When
go list -m -u -json allis issued it produces invalid JSON.What version of Go are you using (
go version)?go1.11
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env)?linux/amd64
What did you do?
Created the following two files in a directory.
foo.go:
go.mod:
Issued this from within the directory:
go list -m -u -json allWhat did you expect to see?
Anything that could be parsed using the encoding/json package. A JSON array would be nice:
What did you see instead?
which is a concatenation of JSONs and cannot be easily parsed using encoding/json.
The text was updated successfully, but these errors were encountered: