Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: don't auto-assign X as reviewer of CL authored by X #27533

Closed
thanm opened this issue Sep 6, 2018 · 1 comment
Closed

x/build/cmd/gopherbot: don't auto-assign X as reviewer of CL authored by X #27533

thanm opened this issue Sep 6, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@thanm
Copy link
Contributor

thanm commented Sep 6, 2018 •
edited by dmitshur

Since 9/5/2018 (CL 121018), gopherbot is now auto-assigning reviewers to CLs based on the entries in https://golang.org/s/owners.

I think it would be useful to insure that the bot doesn't add the author as a reviewer, e.g. if a CL is authored by person X, avoid auto-assigning X as a reviewer for that same CL.
@gopherbot gopherbot added this to the Unreleased milestone Sep 6, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 6, 2018
@andybons andybons changed the title x/build/cmd/gerritbot: don't auto-assign X as reviewer of CL authored by X x/build/cmd/gopherbot: don't auto-assign X as reviewer of CL authored by X Sep 6, 2018
@dmitshur dmitshur mentioned this issue Sep 21, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/140038 mentions this issue: cmd/gopherbot: dont auto-assign author as reviewer

@dmitshur dmitshur mentioned this issue Feb 15, 2019
Open
@golang golang locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @gopherbot @thanm