Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: TestClientWriteError fails intermittently #2752

Closed
alberts opened this issue Jan 21, 2012 · 6 comments
Closed

net/rpc: TestClientWriteError fails intermittently #2752

alberts opened this issue Jan 21, 2012 · 6 comments
Labels
FrozenDueToAge
Milestone
Go1

Comments

@alberts
Copy link
Contributor

alberts commented Jan 21, 2012 

What steps will reproduce the problem?
1. cd $GOROOT/src/pkg/net/rpc
2. gotest -c
3. ./test.sh (included at the bottom)

It takes a few hundred runs to produce a failure.

What do you see instead?

--- FAIL: rpc.TestClientWriteError-8 (0.00 seconds)
server_test.go:492: unexpected value of error: connection is shut down
FAIL

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

linux

Which revision are you using?  (hg identify)

tip

Please provide any additional information below.

test.sh:

#!/bin/sh
set -xe
rm -f out err
while true; do
for procs in 1 2 8 10 50 100; do
GOMAXPROCS=$procs ./6.out -test.v=true >out 2>err || exit 1
echo $?
done
sleep 2
done
@rsc
Copy link
Contributor

rsc commented Jan 24, 2012

Comment 1:

Dmitriy, maybe a good program for the thread sanitizer?

Labels changed: added priority-go1, removed priority-triage.

Owner changed to builder@golang.org.

Status changed to Accepted.

@dvyukov
Copy link
Member

dvyukov commented Jan 24, 2012

Comment 2:

We will take a look.

@dvyukov
Copy link
Member

dvyukov commented Jan 24, 2012

Comment 3:

Owner changed to @dvyukov.

@gopherbot
Copy link

Comment 4 by mpimenov@google.com:

Here is what ThreadSanitizer reports:
WARNING: Possible data race during write of size 1 at 0xf8400010d0: {{{
   T2 (L{}):
    #0  net/rpc..input ~/go/src/pkg/net/rpc/client.go:132
    #1  runtime.goexit ~/go/src/pkg/runtime/proc.c:266
  Concurrent read(s) happened at (OR AFTER) these points:
   T1 (L{}):
    #0  net/rpc..Call ~/go/src/pkg/net/rpc/client.go:286
    #1  net/rpc.TestClientWriteError ~/go/src/pkg/net/rpc/server_test.go:487
    #2  testing.tRunner ~/go/src/pkg/testing/testing.go:254
    #3  runtime.goexit ~/go/src/pkg/runtime/proc.c:266
  Location 0xf8400010d0 is 48 bytes inside a block starting at 0xf8400010a0 of size 80 allocated by T1 from heap:
    #0  net/rpc..Go ~/go/src/pkg/net/rpc/client.go:255
    #1  net/rpc..Call ~/go/src/pkg/net/rpc/client.go:285
    #2  net/rpc.TestClientWriteError ~/go/src/pkg/net/rpc/server_test.go:487
    #3  testing.tRunner ~/go/src/pkg/testing/testing.go:254
    #4  runtime.goexit ~/go/src/pkg/runtime/proc.c:266
}}}

@dvyukov
Copy link
Member

dvyukov commented Jan 25, 2012

Comment 5:

Labels changed: added threadsanitizer.

@dvyukov
Copy link
Member

dvyukov commented Jan 26, 2012

Comment 6:

This issue was closed by revision fa32b16.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1
Development

No branches or pull requests
4 participants
@rsc @alberts @dvyukov @gopherbot