Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: What should the new semver tag be for +incompatible modules? #27432

Closed
marwan-at-work opened this issue Aug 31, 2018 · 2 comments
Closed

cmd/go: What should the new semver tag be for +incompatible modules? #27432

marwan-at-work opened this issue Aug 31, 2018 · 2 comments
Labels
FrozenDueToAge modules

Comments

@marwan-at-work
Copy link
Contributor

Summary

When a +incompatible module decides to introduce a go.mod file and updates all of its import paths to include vX, what should their new git tag be? Should they bump their patch, minor, or major?

What version of Go are you using (go version)?

1.11

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

All

What did you do?

Introduce go.mod to a +incompatible package: google/martian#262

What did you expect to see?

A clear instruction on how to migrate such libraries.

What did you see instead?

I'm not sure if google/martian should go from v2.0.0 to v2.0.1 or v2.1.0 or v3.0.0
@myitcv myitcv added the modules label Aug 31, 2018
@marwan-at-work
Copy link
Contributor Author

I briefly discussed this with Go team members at GopherCon but the question has come up a few times from library owners so I thought I'd create an issue for it.

cc: @bcmills

@acln0 acln0 mentioned this issue Sep 1, 2018
Closed
@bcmills
Copy link
Contributor

bcmills commented Sep 13, 2018

Closing as a dup of (the newly-reopened) #25967.

@bcmills bcmills closed this as completed Sep 13, 2018
@golang golang locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@myitcv @bcmills @gopherbot @marwan-at-work