Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: typedef pointer arguments regression [1.11 backport] #27395

Closed
gopherbot opened this issue Aug 30, 2018 · 4 comments
Closed

cmd/cgo: typedef pointer arguments regression [1.11 backport] #27395

gopherbot opened this issue Aug 30, 2018 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.11.4

Comments

@gopherbot
Copy link

@FiloSottile requested issue #27340 to be considered for backport to the next 1.11 minor release.

@gopherbot please file this to be considered for backport to 1.11 and 1.10. This is a regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 30, 2018
@gopherbot gopherbot mentioned this issue Aug 30, 2018
Closed
@gopherbot gopherbot added this to the Go1.11.1 milestone Aug 30, 2018
@katiehockman katiehockman modified the milestones: Go1.11.1, Go1.11.2 Oct 1, 2018
@bradfitz bradfitz modified the milestones: Go1.11.2, Go1.11.3 Nov 1, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Nov 1, 2018

Not fixed in master yet, so bumping to Go 1.11.3.

@dmitshur dmitshur modified the milestones: Go1.11.3, Go1.11.4 Dec 13, 2018
@FiloSottile FiloSottile added the CherryPickApproved Used during the release process for point releases label Dec 14, 2018
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 14, 2018
@randall77
Copy link
Contributor

I think it is worth backporting.

@gopherbot
Copy link
Author

Change https://golang.org/cl/154277 mentions this issue: [release-branch.go1.11] cmd/cgo: preserve type information across loadDWARF loop

@gopherbot
Copy link
Author

Closed by merging 928a4b6 to release-branch.go1.11.

gopherbot pushed a commit that referenced this issue Dec 14, 2018
@ianlancetaylor @FiloSottile
[release-branch.go1.11] cmd/cgo: preserve type information across loa…
928a4b6 
…dDWARF loop

CL 122575 and its successors introduced a loop calling loadDWARF,
whereas before we only called it once. Pass a single typeConv to each
call, rather than creating a new one in loadDWARF itself. Change the
maps from dwarf.Type to use string keys rather than dwarf.Type keys,
since when the DWARF is reloaded the dwarf.Type pointers will be
different. These changes permit typeConv.Type to return a consistent
value for a given DWARF type, avoiding spurious type conversion errors
due to typedefs loaded after the first loop iteration.

Updates #27340
Fixes #27395

Change-Id: Ic33467bbfca4c54e95909621b35ba2a58216d96e
Reviewed-on: https://go-review.googlesource.com/c/152762
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 6d43587)
Reviewed-on: https://go-review.googlesource.com/c/154277
Run-TryBot: Filippo Valsorda <filippo@golang.org>
@golang golang locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.11.4
Development

No branches or pull requests
6 participants
@bradfitz @FiloSottile @dmitshur @randall77 @gopherbot @katiehockman