New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: testSpliceReaderAtEOF closed connection: got err = splice: invalid argument #27355
Comments
CC @acln0 |
I'm a little confused. Does 92bdfab not handle this correctly by disabling splice on old kernels, or am I reading that commit incorrectly? I don't understand if 2.6.29 or 2.6.35 is the cut-off. Perhaps @benburkert could clarify? |
I am seeing the same issue. |
I'm currently investigating on CentOS 6, and I can reproduce the issue. When I run the I'll continue investigating. |
Change https://golang.org/cl/132096 mentions this issue: |
Change https://golang.org/cl/132281 mentions this issue: |
Refactor TestSplice/readerAtEOF to handle cases where we disable splice on older kernels better. If splice is disabled, net.splice and poll.Splice do not get to observe EOF on the reader, because poll.Splice returns immediately with EINVAL. The test fails unexpectedly, because the splice operation is reported as not handled. This change refactors the test to handle the aforementioned case correctly, by not calling net.splice directly, but using a higher level check. Fixes #27355. Change-Id: I0d5606b4775213f2dbbb84ef82ddfc3bab662a31 Reviewed-on: https://go-review.googlesource.com/132096 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> (cherry picked from commit bd49b3d) Reviewed-on: https://go-review.googlesource.com/132281 Reviewed-by: Andrew Bonventre <andybons@golang.org>
When running tests against the new splice code in the net package from 1.11 the syscall appears to be returning an error on CentOS 6.
What version of Go are you using (
go version
)?go version go1.11 linux/amd64
Does this issue reproduce with the latest release?
Yes, it appears to have been introduced with 1.11
What operating system and processor architecture are you using (
go env
)?The error appears to only occur on CentOS 6 with the standard 2.6.32 kernel. The test passed successfully in a CentOS 6 chroot under a CentOS 7 kernel however, so it seems like it may be related to the older kernel. Also passed on a variety of newer CentOS/Fedora distros without issue.
What did you do?
./run.bash --no-rebuild -v -v -v -k
What did you expect to see?
All tests pass successfully
What did you see instead?
The text was updated successfully, but these errors were encountered: