You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NeedsFixThe path to resolution is known, but the work has not been done.ToolsThis label describes issues relating to any tools in the x/tools repository.
It appears these line-height changes weren't meant to have any visible changes. The reasoning in the CL states:
If the line-height is specified in em, you can just drop the em (it's the default unit for line-height). So here "line-height: 1.4;" would be the right thing.
On my system (Arch Linux, Firefox), this results in visible changes. As an example, here are 2 screenshots. First, we have the original em behavior (taken from the index for package fmt):
And here is the newer behavior following the removal of the ems:
The computed line-height went from 20.8px to 18.2px.
I find the original em version to be more readable. Since it looks like this visible change was inadvertent, could we add the em units back to lines 5 and 15?
The text was updated successfully, but these errors were encountered:
This is my fault. I gave @agnivade bad advice because I confidently mis-remembered how line-heights work and didn't notice the visual difference. Sorry!
agnivade
changed the title
x/tools/godoc: some line-heights became less readable
x/tools/cmd/godoc: some line-heights became less readable
Aug 29, 2018
NeedsFixThe path to resolution is known, but the work has not been done.ToolsThis label describes issues relating to any tools in the x/tools repository.
https://go-review.googlesource.com/c/tools/+/94935 changed some line-height values in godoc/static/style.css, dropping the em unit specifier.
It appears these line-height changes weren't meant to have any visible changes. The reasoning in the CL states:
But em is not the default unit for line-height (see https://developer.mozilla.org/en-US/docs/Web/CSS/line-height).
On my system (Arch Linux, Firefox), this results in visible changes. As an example, here are 2 screenshots. First, we have the original em behavior (taken from the index for package fmt):
And here is the newer behavior following the removal of the ems:
The computed line-height went from 20.8px to 18.2px.
I find the original em version to be more readable. Since it looks like this visible change was inadvertent, could we add the em units back to lines 5 and 15?
The text was updated successfully, but these errors were encountered: