Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc: copying source code in Firefox adds two newlines between lines #27291

Closed
kevinburke opened this issue Aug 27, 2018 · 3 comments
Closed

x/tools/godoc: copying source code in Firefox adds two newlines between lines #27291

kevinburke opened this issue Aug 27, 2018 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@kevinburke
Copy link
Contributor

If I open Firefox copy text from eg. https://golang.org/src/encoding/csv/reader.go?s=3304:5704#L96 (any code page will work), the text gets pasted with a beginning newline and two newlines in between lines, like this:


func (e *ParseError) Error() string {

	if e.Err == ErrFieldCount {

		return fmt.Sprintf("record on line %d: %v", e.Line, e.Err)

	}

I can reproduce with godoc tip. I cannot reproduce in Chrome. I am running the latest Firefox on a new-ish Mac.

I would appreciate if people could comment if they can reproduce with Firefox on Windows or a Linux machine.

I may post this to https://github.com/webcompat/web-bugs as well since the behavior is different between Chrome and Firefox.
@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2018
@agnivade
Copy link
Contributor

Reproduced on FF(60.0.2)+Linux.

@agnivade agnivade added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 28, 2018
@kevinburke
Copy link
Contributor Author

Tracking bug, it's an issue in the browser it seems. https://bugzilla.mozilla.org/show_bug.cgi?id=1273836

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@ALTree
Copy link
Member

ALTree commented Jul 22, 2020

It seems to me that this issue is caused by a Firefox bug, and it's thus not really actionable on the Go side. For this reason, I think we can close here (usually we only keep open issues that are actually actionable); but feel free to comment if you disagree.

@ALTree ALTree closed this as completed Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@kevinburke @agnivade @ALTree @gopherbot