x/tools/cmd/goimports: performance issue with go1.11 in modules #27287

thatguystone · 2018-08-27T19:43:16Z

What version of Go are you using (`go version`)?

go version go1.11 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOCACHE="~/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="~/go"
GOPROXY=""
GORACE=""
GOROOT="~/.gimme/versions/go1.11.linux.amd64"
GOTMPDIR=""
GOTOOLDIR="~/.gimme/versions/go1.11.linux.amd64/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="~/appengine/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build507619798=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Compile goimports with go1.10 and go1.11, then run on google.golang.org/appengine outside of $GOPATH. Full setup:

~ $ git clone --depth=1 https://github.com/golang/appengine.git
Cloning into 'appengine'...
remote: Counting objects: 211, done.
remote: Compressing objects: 100% (194/194), done.
remote: Total 211 (delta 12), reused 103 (delta 9), pack-reused 0
Receiving objects: 100% (211/211), 365.12 KiB | 4.68 MiB/s, done.
Resolving deltas: 100% (12/12), done.
~ $ cd go/src/golang.org/x/tools/cmd/goimports/
~/go/src/golang.org/x/tools/cmd/goimports $ git pull
Already up to date.
~/go/src/golang.org/x/tools/cmd/goimports $ go version
go version go1.10.3 linux/amd64
~/go/src/golang.org/x/tools/cmd/goimports $ go build
~/go/src/golang.org/x/tools/cmd/goimports $ mv goimports ~/appengine/goimports1.10
~/go/src/golang.org/x/tools/cmd/goimports $ eval "$(gimme 1.11)"
go version go1.11 linux/amd64
~/go/src/golang.org/x/tools/cmd/goimports $ go build
~/go/src/golang.org/x/tools/cmd/goimports $ mv goimports ~/appengine/goimports1.11
~/go/src/golang.org/x/tools/cmd/goimports $ cd ~/appengine/

What did you expect to see?

~/appengine $ time ./goimports1.10 -w .

real	0m0.788s
user	0m0.856s
sys	0m0.029s

What did you see instead?

~/appengine $ time ./goimports1.11 -w .

real	0m9.400s
user	0m12.023s
sys	0m4.576s

Outside of $GOPATH, goimports compiled with go1.11 runs much slower. Inside of $GOPATH, it's basically the same:

~/go/src/google.golang.org/appengine $ time goimports1.10 -w . && time goimports1.11 -w .

real	0m0.482s
user	0m0.505s
sys	0m0.020s

real	0m0.439s
user	0m0.464s
sys	0m0.013s

The text was updated successfully, but these errors were encountered:

FiloSottile · 2018-08-30T21:57:24Z

/cc @bradfitz @josharian

myitcv · 2018-08-30T22:01:35Z

/cc @ianthehat

tzneal · 2018-08-31T19:02:26Z

This was caused by a fix to #26504 in f851253, with modules enabled it's exec'ing go list on each import to determine import path names. Temporary fix at http://golang.org/cl/132598 until goimports moves to go/packages.

mitranim · 2018-09-12T11:02:44Z

@tzneal Until this change is merged, could you advise how to pull it, for folks unfamiliar with Gerrit / googlesource?

ianlancetaylor · 2018-09-12T12:42:19Z

@mitranim Click on the Download link in the middle of the screen on the right to get three different ways to fetch the patch.

math2001 · 2018-09-30T05:14:42Z

until goimports moves to go/packages.

When will that be?

myitcv · 2018-10-07T20:45:35Z

@math2001 this work is in progress. For progress updates this is the correct tracking issue (#24661 is the umbrella tracking issue for "all" tools). You might also be interested in following the fortnightly update calls we have as part of the https://groups.google.com/forum/#!forum/golang-tools group.

ianthehat · 2018-10-16T23:51:07Z

Progress in https://golang.org/cl/142697
Mostly working, but not ready to submit.

konstlepa · 2018-10-17T07:48:22Z

Progress in https://golang.org/cl/142697
Mostly working, but not ready to submit.

I tried https://golang.org./cl/128362. It works only if a working directory or its parent contains go.mod. Look imports/dirs.go in the patchset for details.

I use the next script:

#!/bin/bash

argc=$#
argv=($@)

for (( j=0; j<argc; j++ )); do
    if [ ${argv[j]} == "-srcdir" ]; then
            cd $(dirname ${argv[j+1]})
            break
    fi
done

goimports.bin $*

tschellenbach · 2018-11-26T03:15:19Z

Is this fix going to be included in 1.12?

bradfitz · 2018-11-26T05:06:42Z

Is this fix going to be included in 1.12?

goimports isn't part of a release.

heschi · 2018-12-13T19:07:33Z

goimports at tip now uses go/packages for modules. It won't be as fast as non-module mode, since it still has to shell out to go list, but it should be usable. Please file (new) bugs if you have problems.

gopherbot added this to the Unreleased milestone Aug 27, 2018

FiloSottile added the NeedsFix label Aug 30, 2018

bcmills added the modules label Sep 13, 2018

lucastheisen mentioned this issue Sep 20, 2018

Too slow for vscode after upgrading to 1.11 sqs/goreturns#49

Open

bradfitz mentioned this issue Sep 25, 2018

x/tools/imports: does not find imports from go.mod #27865

Closed

flibustenet mentioned this issue Sep 26, 2018

cmd/go: track tools/tooling updates to support modules #24661

Closed

63 tasks

jeremyschlatter mentioned this issue Sep 26, 2018

accounts/abi/bind: stop using goimports in the binding generator ethereum/go-ethereum#17768

Merged

jirfag mentioned this issue Oct 30, 2018

Significant performance issues with goimports and modules golangci/golangci-lint#263

Closed

bvwells mentioned this issue Nov 30, 2018

Generating code for go modules is much slower than under GOPATH go-swagger/go-swagger#1826

Closed

atombender mentioned this issue Dec 5, 2018

Use goimports fork for modules support microsoft/vscode-go#2098

Closed

heschi closed this as completed Dec 13, 2018

thatguystone mentioned this issue Dec 16, 2018

x/tools/cmd/goimports: error "root package %s is missing" #29297

Closed

halseth mentioned this issue Jan 9, 2019

[Makefile] Define make imports lightningnetwork/lnd#2162

Merged

golang locked and limited conversation to collaborators Dec 13, 2019

gopherbot added the FrozenDueToAge label Dec 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/cmd/goimports: performance issue with go1.11 in modules #27287

x/tools/cmd/goimports: performance issue with go1.11 in modules #27287

thatguystone commented Aug 27, 2018

FiloSottile commented Aug 30, 2018

myitcv commented Aug 30, 2018

tzneal commented Aug 31, 2018

mitranim commented Sep 12, 2018 •

edited

Loading

ianlancetaylor commented Sep 12, 2018

math2001 commented Sep 30, 2018

myitcv commented Oct 7, 2018

ianthehat commented Oct 16, 2018

konstlepa commented Oct 17, 2018

tschellenbach commented Nov 26, 2018

bradfitz commented Nov 26, 2018

heschi commented Dec 13, 2018

x/tools/cmd/goimports: performance issue with go1.11 in modules #27287

x/tools/cmd/goimports: performance issue with go1.11 in modules #27287

Comments

thatguystone commented Aug 27, 2018

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

FiloSottile commented Aug 30, 2018

myitcv commented Aug 30, 2018

tzneal commented Aug 31, 2018

mitranim commented Sep 12, 2018 • edited Loading

ianlancetaylor commented Sep 12, 2018

math2001 commented Sep 30, 2018

myitcv commented Oct 7, 2018

ianthehat commented Oct 16, 2018

konstlepa commented Oct 17, 2018

tschellenbach commented Nov 26, 2018

bradfitz commented Nov 26, 2018

heschi commented Dec 13, 2018

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

mitranim commented Sep 12, 2018 •

edited

Loading