Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dl/go1.10: two main functions #27262

Closed
elagergren-spideroak opened this issue Aug 27, 2018 · 4 comments
Closed

dl/go1.10: two main functions #27262

elagergren-spideroak opened this issue Aug 27, 2018 · 4 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@elagergren-spideroak
Copy link

elagergren-spideroak commented Aug 27, 2018 •
edited

What did you do?

go get -u golang.org/dl/...

What did you see instead?

$ go get -u golang.org/dl/...
# golang.org/dl/go1.10
gopath/src/golang.org/dl/go1.10/main.go:22:6: main redeclared in this block
	previous declaration at gopath/src/golang.org/dl/go1.10/go1.10.go:22:6

https://go.googlesource.com/dl/+/master/go1.10/ indicates there's both a main.go and go1.10.go, both of which contain (nearly) the same content. No other dl/ packages have a go1.xx.go file.
@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2018
@dolmen
Copy link
Contributor

dolmen commented Aug 27, 2018

@bradfitz In 1bf763e7e you added main.go, but go1.10.go was already there.

@gopherbot
Copy link

Change https://golang.org/cl/131655 mentions this issue: go1.10: remove duplicate file go1.10.go

@agnivade
Copy link
Contributor

Looks like gopherbot doesn't close issues from dl repos. Closing it since CL has been merged.

gopherbot pushed a commit to golang/dl that referenced this issue Sep 7, 2018
@bradfitz
go1.10: remove duplicate file go1.10.go
60e9c32 
We use main.go everywhere else and I'd added an auto-generated main.go
here in CL 130977.

Fixes golang/go#27262

Change-Id: Ic9a76eb33315e922c2156c76fe4900e218d8787d
Reviewed-on: https://go-review.googlesource.com/131655
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur
Copy link
Contributor

dmitshur commented Sep 7, 2018

Looks like gopherbot doesn't close issues from dl repos.

For posterity, it does now, because #26949 is resolved.

@golang golang locked and limited conversation to collaborators Sep 7, 2019
@dmitshur dmitshur changed the title x/dl: go get -u golang.org/dl/... finds two main functions dl/go1.10: two main functions Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dolmen @agnivade @dmitshur @gopherbot @elagergren-spideroak