Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: Fannkuch benchmark performance regression #27108

Open
kklobe opened this issue Aug 21, 2018 · 5 comments
Open

cmd/compile: Fannkuch benchmark performance regression #27108

kklobe opened this issue Aug 21, 2018 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Milestone
Backlog

Comments

@kklobe
Copy link

kklobe commented Aug 21, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.11rc1 darwin/amd64

Does this issue reproduce with the latest release?

No.

What operating system and processor architecture are you using (go env)?

macOS 10.13.6 (darwin/amd64)

What did you do?

tested the benchmark at:

https://benchmarksgame-team.pages.debian.net/benchmarksgame/program/fannkuchredux-go-1.html

using 1.10.3 and 1.11rc1 with:

time go run fannkuchredux.go 12
time go1.11rc1 run fannkuchredux.go 12

results:
1.10.3: go run fannkuchredux.go 12 44.65s user 0.21s system 372% cpu 12.033 total
1.11rc1: go1.11rc1 run fannkuchredux.go 12 57.70s user 0.24s system 373% cpu 15.528 total

What did you expect to see?

1.11rc1 timings closer to 1.10.3

What did you see instead?

1.11rc1 timings slower than 1.10.3
@bradfitz bradfitz changed the title Fannkuch benchmark performance regression cmd/compile: Fannkuch benchmark performance regression Aug 22, 2018
@bradfitz
Copy link
Contributor

/cc @randall77

@bradfitz bradfitz added this to the Go1.12 milestone Aug 22, 2018
@bradfitz bradfitz added Performance NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 22, 2018
@TocarIP
Copy link
Contributor

TocarIP commented Aug 23, 2018

Disabling branchelim seems to bring performance back to 1.10 level. Interestingly enough, on test/bench/go1/fannkuch disabling CMOV hurts performance by 20%

@navytux
Copy link
Contributor

navytux commented Aug 28, 2018

Possibly related issue about still unfixed Fannkuch11 performance regression from Go1.8 -> Go1.9 time: #18977.

For the reference: Fannkuch11 performance depends heavily on BCE: #24660.

@TocarIP
Copy link
Contributor

TocarIP commented Sep 24, 2018

I've looked at instruction-level profile and found that all conditional moves are out of the hot-spot. Main problem is that enabling branchelim pass caused different register allocation, which in turn put register spills/fills inside the inner loop.

@randall77
Copy link
Contributor

Punting to 1.13, too late for anything major in 1.12.

@randall77 randall77 modified the milestones: Go1.12, Go1.13 Dec 12, 2018
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Projects
Go Compiler / Runtime
Status: Triage Backlog
Milestone
Backlog
Development

No branches or pull requests
8 participants
@bradfitz @rsc @andybons @kklobe @navytux @randall77 @gopherbot @TocarIP