Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: fix data race in exitStatus #2709

Closed
dvyukov opened this issue Jan 16, 2012 · 6 comments
Closed

cmd/go: fix data race in exitStatus #2709

dvyukov opened this issue Jan 16, 2012 · 6 comments
Milestone

Comments

@dvyukov
Copy link
Member

dvyukov commented Jan 16, 2012

go test sometimes yield the following ThreadSanitizer
(http://code.google.com/p/data-race-test/wiki/ThreadSanitizerGo) report:

INFO: T11 has been created by T0 at this point: {{{
    #0   
    #1  main.runTest src/cmd/go/test.go:297
    #2  main.main src/cmd/go/main.go:111
    #3  runtime.main src/pkg/runtime/proc.c:238
}}}
INFO: T0 is program's main thread
INFO: T14 has been created by T0 at this point: {{{
    #0   
    #1  main.runTest src/cmd/go/test.go:297
    #2  main.main src/cmd/go/main.go:111
    #3  runtime.main src/pkg/runtime/proc.c:238
}}}
WARNING: Possible data race during write of size 1 at 0x680e28: {{{
   T11 (L{}):
    #0  main..runTest src/cmd/go/test.go:504
    #1  main._func_004 src/cmd/go/build.go:414
    #2  main._func_005 src/cmd/go/build.go:463
    #3  runtime.goexit src/pkg/runtime/proc.c:266
  Concurrent write(s) happened at (OR AFTER) these points:
   T14 (L{}):
    #0  main..runTest src/cmd/go/test.go:504
    #1  main._func_004 src/cmd/go/build.go:414
    #2  main._func_005 src/cmd/go/build.go:463
    #3  runtime.goexit src/pkg/runtime/proc.c:266
   Race verifier data: 0x4150f5,0x4150f5
}}}

11228:0bce67292a8f tip
@dvyukov
Copy link
Member Author

dvyukov commented Jan 16, 2012

Comment 1:

I am on it.

@dvyukov
Copy link
Member Author

dvyukov commented Jan 17, 2012

Comment 2:

I am not on it anymore.

Owner changed to @rsc.

@rsc
Copy link
Contributor

rsc commented Jan 24, 2012

Comment 3:

Labels changed: added priority-go1, removed priority-triage.

@rsc
Copy link
Contributor

rsc commented Jan 30, 2012

Comment 4:

Labels changed: added go1-must.

@rsc
Copy link
Contributor

rsc commented Jan 31, 2012

Comment 5:

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented Jan 31, 2012

Comment 6:

This issue was closed by revision 64a73b0.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants