Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: please add syscall definitions for FreeBSD #27072

Closed
yurivict opened this issue Aug 18, 2018 · 7 comments
Closed

x/sys/unix: please add syscall definitions for FreeBSD #27072

yurivict opened this issue Aug 18, 2018 · 7 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD
Milestone

Comments

@yurivict
Copy link

See the downstream bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230736

@ianlancetaylor ianlancetaylor changed the title Please add syscall definitions for FreeBSD x/sys/unix: please add syscall definitions for FreeBSD Aug 19, 2018
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2018
@ianlancetaylor
Copy link
Contributor

The bug report is asking for at least the following system calls to be added to the FreeBSD target:

SYS_SEMOP
SYS_SEMGET
SYS_SEMCTL
SYS_MSGSND
SYS_MSGRCV
SYS_MSGGET
SYS_MSGCTL
SYS_SHMAT
SYS_SHMDT
SYS_SHMGET

These values should not be added to the syscall package, which is frozen, but they should be added to the golang.org/x/sys/unix package.

@ianlancetaylor ianlancetaylor added help wanted OS-FreeBSD NeedsFix The path to resolution is known, but the work has not been done. labels Aug 19, 2018
@yurivict
Copy link
Author

Actually, all system calls that are defined in the FreeBSD kernel should be defined in go, including module-dependent ones.

@ianlancetaylor
Copy link
Contributor

@yurivict I agree. Not sure what you mean by writing "actually."

@yurivict
Copy link
Author

Some of the system calls are labeled as optional. All of them, including the optional ones, should be available in go.

@jharshman
Copy link
Contributor

Just poking around to see why this is, and it looks like there are a lot of un-implemented system calls. See syscall_freebsd.go

The mksysnum_freebsd.pl regex filters syscalls of type NOSTD which accounts for missing ones.

@yurivict
Copy link
Author

yurivict commented Aug 19, 2018

mksysnum_freebsd.pl shouldn't filter out NOSTD calls.
They are regular calls defined in kernel modules that might be missing on some systems, but are usually present.

@gopherbot
Copy link

Change https://golang.org/cl/129855 mentions this issue: unix: add NOSTD syscall numbers on FreeBSD

@golang golang locked and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD
Projects
None yet
Development

No branches or pull requests

4 participants