Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.11: add note about go run supporting for go run pkg or go run . #27048

Closed
wants to merge 5 commits into from
Closed

Conversation

komuw
Copy link
Contributor

@komuw komuw commented Aug 17, 2018

Fixes #27047

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Aug 17, 2018
@komuw
Copy link
Contributor Author

komuw commented Aug 17, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Aug 17, 2018
@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 12446:

Uploaded patch set 3: Patch Set 2 was rebased.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 22285:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 6365:

Patch Set 3: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5065:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 3:

Ping author


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 9107176) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/129696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 936fbf0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/129696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. and removed cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. labels Dec 4, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Dec 4, 2018
@gopherbot
Copy link

Message from komu wairagu:

Patch Set 7:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 7: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: f28ab62) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/129696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from komu wairagu:

Patch Set 8: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 5, 2018
Fixes #27047

Change-Id: I0dd40201fc03e87fbc674b47bdf9315f1783d6c2
GitHub-Last-Rev: f28ab62
GitHub-Pull-Request: #27048
Reviewed-on: https://go-review.googlesource.com/c/129696
Reviewed-by: komu wairagu <komuw05@gmail.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 8: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/129696.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/129696 has been merged.

@gopherbot gopherbot closed this Dec 5, 2018
gopherbot pushed a commit that referenced this pull request Dec 14, 2018
…for go run pkg or go run .

Fixes #27047

Change-Id: I0dd40201fc03e87fbc674b47bdf9315f1783d6c2
GitHub-Last-Rev: f28ab62
GitHub-Pull-Request: #27048
Reviewed-on: https://go-review.googlesource.com/c/129696
Reviewed-by: komu wairagu <komuw05@gmail.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
(cherry picked from commit 352f1b7)
Reviewed-on: https://go-review.googlesource.com/c/152744
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants