New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/go1.11: add note about go run supporting for go run pkg or go run . #27048
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Message from Gerrit User 12446: Uploaded patch set 3: Patch Set 2 was rebased. Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Message from Gerrit User 22285: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Message from Gerrit User 6365: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Message from Gerrit User 5065: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Message from Andrew Bonventre: Patch Set 3: Ping author Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
This PR (HEAD: 9107176) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/129696 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 936fbf0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/129696 to see it. Tip: You can toggle comments from me using the |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
CLAs look good, thanks! |
Message from komu wairagu: Patch Set 7: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Message from Andrew Bonventre: Patch Set 7: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
This PR (HEAD: f28ab62) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/129696 to see it. Tip: You can toggle comments from me using the |
Message from komu wairagu: Patch Set 8: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
Fixes #27047 Change-Id: I0dd40201fc03e87fbc674b47bdf9315f1783d6c2 GitHub-Last-Rev: f28ab62 GitHub-Pull-Request: #27048 Reviewed-on: https://go-review.googlesource.com/c/129696 Reviewed-by: komu wairagu <komuw05@gmail.com> Reviewed-by: Andrew Bonventre <andybons@golang.org>
Message from Andrew Bonventre: Patch Set 8: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/129696. |
This PR is being closed because golang.org/cl/129696 has been merged. |
…for go run pkg or go run . Fixes #27047 Change-Id: I0dd40201fc03e87fbc674b47bdf9315f1783d6c2 GitHub-Last-Rev: f28ab62 GitHub-Pull-Request: #27048 Reviewed-on: https://go-review.googlesource.com/c/129696 Reviewed-by: komu wairagu <komuw05@gmail.com> Reviewed-by: Andrew Bonventre <andybons@golang.org> (cherry picked from commit 352f1b7) Reviewed-on: https://go-review.googlesource.com/c/152744 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Fixes #27047