Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: internal/modconv TestConvertLegacyConfig wrong golden output #27043

Closed
ALTree opened this issue Aug 16, 2018 · 2 comments
Closed

cmd/go: internal/modconv TestConvertLegacyConfig wrong golden output #27043

ALTree opened this issue Aug 16, 2018 · 2 comments
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@ALTree
Copy link
Member

ALTree commented Aug 16, 2018

The longtest builder (the one running the tests without -short) is failing on the cmd/go/internal/modconv test suite, on the TestConvertLegacyConfig, with the following output:

--- FAIL: TestConvertLegacyConfig (29.11s)
    --- FAIL: TestConvertLegacyConfig/github.com_golang_dep_v0.4.0 (6.83s)
        convert_test.go:170: final go.mod:
            module github.com/golang/dep
            
            require (
            	github.com/Masterminds/vcs v1.11.1
            	github.com/armon/go-radix v0.0.0-20160115234725-4239b77079c7
            	github.com/boltdb/bolt v1.3.1
            	github.com/go-yaml/yaml v0.0.0-20170407172122-cd8b52f8269e
            	github.com/golang/protobuf v0.0.0-20170901042739-5afd06f9d81a
            	github.com/jmank88/nuts v0.3.0
            	github.com/nightlyone/lockfile v0.0.0-20170707060451-e83dc5e7bba0
            	github.com/pelletier/go-toml v0.0.0-20171218135716-b8b5e7696574
            	github.com/pkg/errors v0.8.0
            	github.com/sdboyer/constext v0.0.0-20170321163424-836a14457353
            	golang.org/x/net v0.0.0-20170828231752-66aacef3dd8a
            	golang.org/x/sync v0.0.0-20170517211232-f52d1811a629
            	golang.org/x/sys v0.0.0-20170830134202-bb24a47a89ea
            )
            
            
            want:
            module github.com/golang/dep
            
            require (
            	github.com/Masterminds/semver v0.0.0-20170726230514-a93e51b5a57e
            	github.com/Masterminds/vcs v1.11.1
            	github.com/armon/go-radix v0.0.0-20160115234725-4239b77079c7
            	github.com/boltdb/bolt v1.3.1
            	github.com/go-yaml/yaml v0.0.0-20170407172122-cd8b52f8269e
            	github.com/golang/protobuf v0.0.0-20170901042739-5afd06f9d81a
            	github.com/jmank88/nuts v0.3.0
            	github.com/nightlyone/lockfile v0.0.0-20170707060451-e83dc5e7bba0
            	github.com/pelletier/go-toml v0.0.0-20171218135716-b8b5e7696574
            	github.com/pkg/errors v0.8.0
            	github.com/sdboyer/constext v0.0.0-20170321163424-836a14457353
            	golang.org/x/net v0.0.0-20170828231752-66aacef3dd8a
            	golang.org/x/sync v0.0.0-20170517211232-f52d1811a629
            	golang.org/x/sys v0.0.0-20170830134202-bb24a47a89ea
            )
FAIL
FAIL	cmd/go/internal/modconv	29.435s

Example: https://build.golang.org/log/323efedfa71344f4842b1965240875d16c199d50

I can't reproduce the failure on my machine.
@ALTree ALTree added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. modules labels Aug 16, 2018
@ALTree ALTree added this to the Go1.11 milestone Aug 16, 2018
@rsc
Copy link
Contributor

rsc commented Aug 17, 2018

The test is wrong: it should not expect the semver conversion to succeed.
The semver conversion is looking for a commit hash from a pull request,
one that was not actually pulled into the repo.
It is present in Git if you look at refs/pulls/nnnnn or whatever the ref is,
but not in the main branches and tags.
Recent changes cut the search down to main branches and tags,
which is more appropriate.

The test should be updated. Doesn't matter much for Go 1.11.

@rsc rsc modified the milestones: Go1.11, Go1.12 Aug 17, 2018
@rsc rsc changed the title cmd/go: internal/modconv TestConvertLegacyConfig failure on longtest-builder cmd/go: internal/modconv TestConvertLegacyConfig wrong golden output Aug 17, 2018
@rsc rsc added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 17, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/129800 mentions this issue: cmd/go/internal/modconv: fix TestConvertLegacyConfig expectations

@thepudds thepudds mentioned this issue Aug 25, 2018
Closed
@gopherbot gopherbot mentioned this issue Apr 25, 2019
Closed
@golang golang locked and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@rsc @ALTree @gopherbot