Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: "please backport" doesn't know about future Go releases #27040

Closed
dmitshur opened this issue Aug 16, 2018 · 3 comments
Closed

x/build/cmd/gopherbot: "please backport" doesn't know about future Go releases #27040

dmitshur opened this issue Aug 16, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

In #27030 (comment), @bradfitz said:

@gopherbot, please back​port to 1.11.

@gopherbot instead back​ported for 1.10 and 1.9:

image

The reason it did so is because it doesn't know about 1.11 yet, it's a future release. b.getMajorReleases(ctx) returns 1.9 and 1.10 only. Since 1.11 wasn't recognized, the default behavior is to back​port to supported major releases (current and previous).

How do we want to fix this? Just add support for back​porting to the next major release (current+1)? Or something else?

/cc @bradfitz @andybons @FiloSottile

(I'm using a zero width space to prevent @gopherbot from back​porting this issue.)
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Aug 16, 2018
@gopherbot gopherbot added this to the Unreleased milestone Aug 16, 2018
This was referenced Aug 16, 2018
Closed
Closed
@dmitshur
Copy link
Contributor Author

This happened again in #27105. /cc @andybons

@andybons
Copy link
Member

How do we want to fix this? Just add support for back​porting to the next major release (current+1)? Or something else?

I think this is a reasonable thing to do. If we encounter issues we can revisit.

@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Aug 22, 2018
@gopherbot
Copy link

Change https://golang.org/cl/131077 mentions this issue: cmd/gopherbot: Allow backporting to the upcoming Go release

@golang golang locked and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @dmitshur @gopherbot @katiehockman