Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: many repeating js-wasm builds running every 15 seconds #27012

Closed
dmitshur opened this issue Aug 15, 2018 · 4 comments
Closed

x/build/cmd/coordinator: many repeating js-wasm builds running every 15 seconds #27012

dmitshur opened this issue Aug 15, 2018 · 4 comments
Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

Over at https://farmer.golang.org/#completed, I'm seeing a large number of js-wasm builders start every 15 seconds for the exact same commit:

image

Each one completes within a second with the following output:

  builder: js-wasm
      rev: dea961ebd9f871b39b3bdaab32f952037f28cd71
 buildlet: (nil *buildlet.Client)
  started: 2018-08-15 21:48:11.498031687 +0000 UTC m=+521730.873199532
    ended: 2018-08-15 21:48:11.658471517 +0000 UTC m=+521731.033639405
  success: true

Events:
  2018-08-15T21:48:11Z ask_maintner_has_ancestor 
  2018-08-15T21:48:11Z finish_ask_maintner_has_ancestor after 24.5ms
  2018-08-15T21:48:11Z skipped_build_missing_dep 

Build log:
skipping build; commit dea961ebd9f871b39b3bdaab32f952037f28cd71 lacks ancestor 3dced519cbabc213df369d9112206986e62687fa

This seems unintentional and suboptimal, right? If so, I'd like to better understand why it happens and try to fix it.

/cc @bradfitz
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-wasm WebAssembly issues labels Aug 15, 2018
@gopherbot gopherbot added this to the Unreleased milestone Aug 15, 2018
@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 15, 2018 •
edited

Not sure how relevant this is, but both commits exist:

  • dea961e (it's on release-branch.go1.10 branch)
  • 3dced51 (it's on master branch, included as part of go1.11rc1, go1.11beta3, go1.11beta2, and go1.11beta1 tags)

And there are 1735 commits between them in one direction, and 72 commits between in the other.

@bradfitz
Copy link
Contributor

Couple things:

  • this isn't great, but isn't terrible: we're stopping before creating a VM at least.
  • we shouldn't be trying to do js-wasm builds for release-branch.go1.10 or many other old branches
  • we should keep a global cache wasSkippedBuild[builderRev{builder, rev}] = true once discovered, to avoid enqueuing that duplicate work in findWork* later.

@bradfitz bradfitz changed the title x/build: many repeating js-wasm builds running every 15 seconds x/build/cmd/coordinator: many repeating js-wasm builds running every 15 seconds Aug 15, 2018
@neelance
Copy link
Member

@dmitshur Is this still an issue?

@dmitshur
Copy link
Contributor Author

It does not appear to be. I've checked now, things look good, and I have not observed other occurrences in a long time.

"we shouldn't be trying to do js-wasm builds for release-branch.go1.10 or many other old branches" is resolved.

I don't think "a global wasSkippedBuild cache" was implemented. But it doesn't seem to be very relevant now.

Let's close this as resolved. If we find a problem, we can file a new issue with with current and actionable information.

@golang golang locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @neelance @dmitshur @gopherbot