Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: clean on module uses directory name #26991

Closed
DeedleFake opened this issue Aug 14, 2018 · 4 comments
Closed

cmd/go: clean on module uses directory name #26991

DeedleFake opened this issue Aug 14, 2018 · 4 comments
Labels
GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@DeedleFake
Copy link

What version of Go are you using (go version)?

go version go1.11rc1 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="$HOME/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="$HOME/go"
GOPROXY=""
GORACE=""
GOROOT="$HOME/sdk/go1.11rc1"
GOTMPDIR=""
GOTOOLDIR="/Users/moquality/sdk/go1.11rc1/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/var/folders/6b/nk1h2bp93yn4_c35zvn2845c0000gq/T/tmp.kodrU4ryxD/node/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/6b/nk1h2bp93yn4_c35zvn2845c0000gq/T/go-build046724770=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

mkdir example
cd example
go mod init modname
echo 'package main; func main() {println("This is an example.")}' > example.go
go build -v # This produces a file called 'modname'.
go clean -x # This attempts to delete a file called 'example'.

What did you expect to see?

go clean should use the module name to delete rather than the directory name.

What did you see instead?

go clean attempted to use the directory name to delete the previously created executable.
@andybons andybons added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. modules labels Aug 15, 2018
@andybons andybons added this to the Unplanned milestone Aug 15, 2018
@andybons
Copy link
Member

@rsc @bcmills @ianlancetaylor

@rsc rsc modified the milestones: Unplanned, Go1.12 Aug 18, 2018
@bcmills bcmills mentioned this issue Sep 11, 2018
Closed
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 13, 2018
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 13, 2018
@bcmills
Copy link
Contributor

bcmills commented Sep 13, 2018

Likely the same root cause as #27283.

@rsc
Copy link
Contributor

rsc commented Oct 25, 2018

Possibly same root cause but possibly not. In any event I agree it should use the final (non-version) element of the module path.

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gabyhelp gabyhelp mentioned this issue Aug 30, 2024
Closed
@seankhliao seankhliao added the GoCommand cmd/go label Feb 22, 2025
@matloob
Copy link
Contributor

matloob commented Apr 1, 2025

The current behavior is that we try to delete both:

matloob@matloob-mac example % go clean -x
cd /Users/matloob/Desktop/example
rm -f example example.exe modname modname.exe example.test example.test.exe modname.test modname.test.exe example example.exe

So I think we now clean the proper files? There is the question of whether we still want to delete the example files, but that can be a different issue if it's a problem for people.

@matloob matloob closed this as completed Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@rsc @DeedleFake @andybons @bcmills @gopherbot @seankhliao @matloob