Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dl/internal/genv: the release notes link is wrong most of the times #26976

Closed
FiloSottile opened this issue Aug 14, 2018 · 3 comments
Closed
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@FiloSottile
Copy link
Contributor

See the release notes at https://golang.org/doc/go1.11beta3

That's not a valid release note link. The generator should do something smart where it links to the major for beta and rc, and to the blurb anchor for minor releases.

@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 14, 2018
@FiloSottile FiloSottile added this to the Unreleased milestone Aug 14, 2018
@agnivade
Copy link
Contributor

agnivade commented Feb 3, 2019

@FiloSottile - Which blurb anchor are you referring to ? I don't see any minor release specific anchor in https://golang.org/doc/go1.11.

@FiloSottile
Copy link
Contributor Author

I didn't make it clear, but I meant links like this: https://golang.org/doc/devel/release.html#go1.11.minor

@FiloSottile FiloSottile added Suggested Issues that may be good for new contributors looking for work to do. help wanted labels Feb 3, 2019
@gopherbot
Copy link

Change https://golang.org/cl/160920 mentions this issue: dl/version: fix release notes link for minor versions

@golang golang locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

3 participants