Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: fix resource leak in documentation #26970

Closed
rillig opened this issue Aug 13, 2018 · 1 comment
Closed

runtime/pprof: fix resource leak in documentation #26970

rillig opened this issue Aug 13, 2018 · 1 comment
Labels
Documentation FrozenDueToAge
Milestone
Go1.12

Comments

@rillig
Copy link
Contributor

rillig commented Aug 13, 2018

Does this issue reproduce with the latest release?

yes

What did you do?

I copied the example code from runtime/pprof into my project and used it. It worked well.
Today I wrote a test for that piece of code, and I could not delete the profiling file because it was still busy.
Adding the appropriate f.Close() call fixed the problem.
@gopherbot
Copy link

Change https://golang.org/cl/129195 mentions this issue: runtime/pprof: fix resource leak in documentation

@golang golang locked and limited conversation to collaborators Aug 22, 2019
@dmitshur dmitshur added this to the Go1.12 milestone Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@dmitshur @rillig @gopherbot