Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: go1.10 behavior emits incorrect Imports #26966

Closed
alandonovan opened this issue Aug 13, 2018 · 1 comment
Closed

x/tools/go/packages: go1.10 behavior emits incorrect Imports #26966

alandonovan opened this issue Aug 13, 2018 · 1 comment
Labels
FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@alandonovan
Copy link
Contributor

alandonovan commented Aug 13, 2018

$ git sync e104082
$ go build ./go/packages/gopackages
$ PATH=$HOME/go1.10/bin ./gopackages -test fmt
Go package "fmt": ...
Go package "fmt [fmt.test]": ...
Go package "fmt_test [fmt.test]":
        package fmt_test
        has no exported type info
        file /usr/local/google/home/adonovan/go1.10/src/fmt/example_test.go
        file /usr/local/google/home/adonovan/go1.10/src/fmt/fmt_test.go
        file /usr/local/google/home/adonovan/go1.10/src/fmt/scan_test.go
        file /usr/local/google/home/adonovan/go1.10/src/fmt/stringer_test.go
        import "bufio"
        import "bytes"
        import "errors"
        import "fmt [fmt.test]"  # should say "fmt" => "fmt [fmt.test]"
        ...
        import "testing" # should say: import "testing" => "testing [fmt.test]"
        import "testing/iotest" # should say: import "testing/iotest" => "testing/iotest [fmt.test]"
        ...
@gopherbot gopherbot added this to the Unreleased milestone Aug 13, 2018
@alandonovan alandonovan changed the title x/tools/go/packages: x/tools/go/packages: go1.10 behavior emits incorrect Imports Aug 13, 2018
@alandonovan alandonovan self-assigned this Aug 13, 2018
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@stamblerre
Copy link
Contributor

Given that we only support Go 1.14 and Go 1.13 currently, going to close this issue. Even if gopls commits to supporting older Go versions, we won't go back before 1.11.

@golang golang locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants