Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/internal/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} #26965

Closed
dmitshur opened this issue Aug 13, 2018 · 4 comments
Closed

x/website/internal/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} #26965

dmitshur opened this issue Aug 13, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 13, 2018 •
edited

https://golang.org/dl/internal/version?go-get=1 is 404.

It should be serving something similar to https://golang.org/x/tools/go/vcs?go-get=1, etc.

$ export GOPATH=/tmp/empty
$ go get golang.org/dl/internal/version
package golang.org/dl/internal/version: unrecognized import path "golang.org/dl/internal/version" (parse https://golang.org/dl/internal/version?go-get=1: no go-import meta tags ())

$ goexec 'vcs.RepoRootForImportPath("golang.org/dl/internal/version", false)'
(*vcs.RepoRoot)(nil)
(*errors.errorString)(&errors.errorString{
	s: (string)("unrecognized import path \"golang.org/dl/internal/version\""),
})

This causes https://godoc.org/golang.org/dl/internal/version to show not found, etc.

This affects golang.org/dl/internal/genv package too.
@dmitshur dmitshur changed the title dl/internal/version: go-import meta tag isn't served godoc/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} Aug 13, 2018
@dmitshur dmitshur added the Builders x/build issues (builders, bots, dashboards) label Aug 13, 2018
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 13, 2018
@andybons andybons added this to the Unreleased milestone Aug 13, 2018
@dmitshur dmitshur removed the Builders x/build issues (builders, bots, dashboards) label Aug 13, 2018
@bradfitz
Copy link
Contributor

True, but kinda low priority, no? This only affects people trying to go get those internal packages directly, rather than go-getting the actual go1.N.M commands?

@dmitshur
Copy link
Contributor Author

Yes, this is a very minor issue. Anyone just doing go get golang.org/dl/gox.y.z isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).

@dmitshur dmitshur changed the title godoc/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} x/website/internal/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} Feb 27, 2019
@seankhliao
Copy link
Member

this still 404s but no longer seems relevant due to module mode? doc is available at https://pkg.go.dev/golang.org/dl/internal/version

@dmitshur
Copy link
Contributor Author

dmitshur commented Jan 18, 2022 •
edited

Yeah, as far as I can tell, because of how package → module resolution works (documented at https://go.dev/ref/mod#resolve-pkg-mod), in module mode it appears to be sufficient as long as ?go-get=1 works on the module root. At least I'm not aware of any concrete ways that this issue is a problem in module mode.

I can close this issue for now, and consider reopening if we find a good reason to.

CC @bcmills, @matloob.

@golang golang locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @andybons @dmitshur @gopherbot @seankhliao