-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: mirror the "dl" repo to GitHub #26949
Comments
There's just little reason to put it on GitHub as it's auto-generated. I don't expect any PRs to it. |
If it's not an issue, I think its good to mirror it on github to be consistent with other repos. I wanted to take a look at the code one day and was surprised to not find it in github. #26810 may be one such issue where a PR can be expected. |
I'm amused about "It doesn't need to be on GitHub since there won't be any PRs" since until a few months ago all our repos were on GitHub and none of them accepted PRs. :-P |
My argument was two sentences that were mostly unrelated, but I guess that wasn't obvious.
Bullet 1 is just the code is boring. We can publish boring code, though. Much of it already is. And probably better to not have any snowflake repos. |
I agree with Brad's arguments, the value added is not very high. However, I think we should do it, for the following 2 reasons:
|
All yours. |
Change https://golang.org/cl/133896 mentions this issue: |
…itelist In golang/go#23223, we've created a new subrepository: https://go.googlesource.com/dl Unlike other subrepositories, there isn't a mirror on GitHub yet: https://github.com/golang/dl (404 at this moment) We want to include it in the whitelist for mirroring to GitHub, including mirroring its pull requests to Gerrit. The motivation is to make this subrepository consistent with all others and prevent people from running into an unexpected situation when some repos are mirrored but some aren't. We don't actually expect much contribution activity to the dl subrepo, because it's very narrow in scope and mostly generated code. Updates golang/go#26949. Change-Id: Id995bb3d97b8eb328e6c6bba6714bc74fbefb942 Reviewed-on: https://go-review.googlesource.com/133896 Reviewed-by: Andrew Bonventre <andybons@golang.org>
Change https://golang.org/cl/134117 mentions this issue: |
With CL 133896 merged, all relevant components redeployed, and some additional steps taken (to be documented), this is done. Mirroring the dl repo to GitHub, and its PRs back to Gerrit now works. The last thing to confirm after this is that googlebot will apply the "cla: yes"/"cla: no" labels on future PRs. |
Verified that it works well in golang/dl#2: |
It seems that getting TryBots to be functional on the new repo would require additional steps that haven't been done yet. When I tried to run them in CL 134435, they failed with build logs like: Sample Build Log
Not planning to spend time on this now; just making notes for future reference. |
It's not needed. It's not there in other subrepos: - https://github.com/golang/image/blob/c73c2afc3b812cdd6385de5a50616511c4a3d458/codereview.cfg - https://github.com/golang/net/blob/161cd47e91fd58ac17490ef4d742dc98bb4cf60e/codereview.cfg Using this to test PRs for golang/go#26949. Change-Id: I7152ea2dae1a511928e787598696274cf2b315f9 GitHub-Last-Rev: 51dbb14 GitHub-Pull-Request: #1 Reviewed-on: https://go-review.googlesource.com/134117 Reviewed-by: Andrew Bonventre <andybons@golang.org>
Issue #23223 has resulted in the creation of a new repository:
https://go.googlesource.com/dl
That new repository is currently not mirrored to GitHub, hence this is 404:
https://github.com/golang/dl (404)
Is that the result of a conscious decision? Or has the decision not been made yet, and this is a potential follow-up task? /cc @bradfitz @andybons
The text was updated successfully, but these errors were encountered: