Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/mod_patterns fails on nocgo builders #26906

Closed
bcmills opened this issue Aug 9, 2018 · 5 comments
Closed

cmd/go: TestScript/mod_patterns fails on nocgo builders #26906

bcmills opened this issue Aug 9, 2018 · 5 comments
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 9, 2018

https://build.golang.org/log/d85e77363e5630d9967e59d5f7ab81921c2893bf

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_patterns (0.02s)
        script_test.go:151: 
            # 'go list all' should list all of the packages used (directly or indirectly) by
            # the packages in the main module, but no other packages from the standard
            # library or active modules. (0.018s)
            > go list all
            [stdout]
            example.com/m/useunicode
            example.com/m/useunsafe
            unicode
            unsafe
            [stderr]
            can't load package: package example.com/m/useC: build constraints exclude all Go files in $WORK/gopath/src/m/useC
            [exit status 1]
            FAIL: testdata/script/mod_patterns.txt:8: unexpected command failure

CC @rsc
@bcmills bcmills added modules NeedsFix The path to resolution is known, but the work has not been done. labels Aug 9, 2018
@bcmills bcmills added this to the Go1.11 milestone Aug 9, 2018
@bcmills
Copy link
Contributor Author

bcmills commented Aug 9, 2018

The failure was introduced with the test itself (https://golang.org/cl/128637), so it's not obvious to me how long it's been broken.

@gopherbot
Copy link

Change https://golang.org/cl/128879 mentions this issue: cmd/go: skip TestScript/mod_patterns on nocgo builders

gopherbot pushed a commit that referenced this issue Aug 9, 2018
cmd/go: skip TestScript/mod_patterns on nocgo builders
da1da23 
Updates #26906.

Change-Id: I61b08180aefe9cfc109a1009ca251ee6970eb2df
Reviewed-on: https://go-review.googlesource.com/128879
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bcmills
Copy link
Contributor Author

bcmills commented Aug 9, 2018

CC: @rsc, while you're looking at go list error handling...

@rsc
Copy link
Contributor

rsc commented Aug 10, 2018

It's breaking my next CL to submit, so I will fix it there.

@gopherbot
Copy link

Change https://golang.org/cl/128358 mentions this issue: cmd/go: fix module loader and test-only dependencies

@0intro 0intro mentioned this issue Aug 10, 2018
Closed
@golang golang locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@rsc @bcmills @gopherbot