Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: convert replacements from vendor.conf #26892

Closed
RalphCorderoy opened this issue Aug 9, 2018 · 2 comments
Closed

cmd/go: convert replacements from vendor.conf #26892

RalphCorderoy opened this issue Aug 9, 2018 · 2 comments
Labels
FrozenDueToAge modules
Milestone
Go1.12

Comments

@RalphCorderoy
Copy link

Viewing tip's source, https://github.com/golang/go/blob/master/src/cmd/go/internal/modconv/vconf.go only uses the first two fields of vendor.conf's line and ignores the rest, but https://github.com/docker/distribution/blob/master/vendor.conf#L50 specifies a forked repo with

rsc.io/letsencrypt e770c10b0f1a64775ae91d240407ce00d1a5bdeb https://github.com/dmcgowan/letsencrypt.git

so errors like

go: converting vendor.conf: stat rsc.io/letsencrypt@e770c10b0f1a64775ae91d240407ce00d1a5bdeb: unknown revision e770c10b0f1a64775ae91d240407ce00d1a5bdeb

result because e77 is in dmcgowan, not rsc.io.
@bcmills
Copy link
Contributor

bcmills commented Aug 9, 2018

See also #25556.

CC: @oiooj

@bcmills bcmills changed the title cmd/go: go mod converting vendor.conf ignores pertinent third field cmd/go: convert replacements from vendor.conf Aug 9, 2018
@bcmills bcmills added the modules label Aug 9, 2018
@bcmills bcmills added this to the Go1.12 milestone Aug 9, 2018
@rsc
Copy link
Contributor

rsc commented Aug 10, 2018

Duplicate of #25556, which is meant to cover all the possible systems.

@rsc rsc closed this as completed Aug 10, 2018
@golang golang locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@rsc @RalphCorderoy @bcmills @gopherbot